From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10653 invoked by alias); 27 Mar 2007 20:20:33 -0000 Received: (qmail 10639 invoked by uid 22791); 27 Mar 2007 20:20:31 -0000 X-Spam-Check-By: sourceware.org Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Mar 2007 21:20:25 +0100 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id BB756121FE for ; Tue, 27 Mar 2007 22:20:23 +0200 (CEST) From: Andreas Schwab To: gdb-patches@sourceware.org Subject: Re: Signed vs. unsigned adresses in solib-svr4 References: <20070327192144.GK28164@caradoc.them.org> X-Yow: If I pull this SWITCH I'll be RITA HAYWORTH!! Or a SCIENTOLOGIST! Date: Tue, 27 Mar 2007 20:20:00 -0000 In-Reply-To: <20070327192144.GK28164@caradoc.them.org> (Daniel Jacobowitz's message of "Tue, 27 Mar 2007 15:21:44 -0400") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00280.txt.bz2 Daniel Jacobowitz writes: > On Tue, Mar 27, 2007 at 09:16:28PM +0200, Andreas Schwab wrote: >> All but two places in solib-svr4.c assume unsigned target addresses. This >> patch fixes these two occurences of extract_signed_integer to make things >> consistent. >> >> Andreas. >> >> 2007-03-27 Andreas Schwab >> >> * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use >> extract_unsigned_integer instead of extract_signed_integer. >> (LM_DYNAMIC_FROM_LINK_MAP): Likewise. > > I'd rather not unless this fixes a real problem If your CORE_ADDR is 64bit, but the target is 32bit you get an address that does not exist on the target. > - since I know that the assumption is wrong for MIPS. Isn't there an > extract_address or something like that which would be suitable? There is extract_typed_address, but I don't know how to construct the struct type that it needs. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."