From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34113-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 32098 invoked by alias); 27 Jun 2004 18:12:28 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32082 invoked from network); 27 Jun 2004 18:12:26 -0000
Received: from unknown (HELO Cantor.suse.de) (195.135.220.2)
  by sourceware.org with SMTP; 27 Jun 2004 18:12:26 -0000
Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by Cantor.suse.de (Postfix) with ESMTP id 70BAC7E24ED;
	Sun, 27 Jun 2004 20:06:14 +0200 (CEST)
To: Elena Zannoni <ezannoni@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: -file-list-exec-source-files
References: <20040225040059.GB19094@white>
	<16456.65451.461753.66554@localhost.redhat.com>
	<20040306155700.GA9439@white> <20040311132508.GA2504@white>
	<20040329205545.GA26696@white> <20040405214043.GA2052@white>
	<20040412150620.GA9464@white> <20040420141001.GB4465@white>
	<uisft98sz.fsf@elta.co.il>
	<16519.59247.93650.941260@localhost.redhat.com>
	<20040426130529.GA11975@white>
From: Andreas Schwab <schwab@suse.de>
X-Yow: ..  One FISHWICH coming up!!
Date: Sun, 27 Jun 2004 18:12:00 -0000
In-Reply-To: <20040426130529.GA11975@white> (Bob Rossi's message of "Mon, 26
 Apr 2004 09:05:30 -0400")
Message-ID: <je3c4gooyy.fsf@sykes.suse.de>
User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2004-06/txt/msg00605.txt.bz2

Bob Rossi <bob@brasko.net> writes:

> +/* Finds the fullname that a symtab represents.
> +
> +   If this functions finds the fullname, it will save it in ps->fullname
> +   and it will also return the value.
>  
> +   If this function fails to find the file that this symtab represents,
> +   NULL will be returned and ps->fullname will be set to NULL.  */

This causes gdb to crash in lookup_symtab.

    if (full_path != NULL)
      {
	const char *fp = symtab_to_fullname (s);
	if (FILENAME_CMP (full_path, fp) == 0)
	  {
	    return s;
	  }
      }

    if (real_path != NULL)
      {
	char *rp = gdb_realpath (symtab_to_fullname (s));
        make_cleanup (xfree, rp);
	if (FILENAME_CMP (real_path, rp) == 0)
	  {
	    return s;
	  }
      }

Neither of these places expect symtab_to_fullname to return NULL.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."