Re: [commited] Detect bad debug info

Andreas Schwab
2008-09-24T13:00:57Z

Andreas Schwab <schwab@suse.de> writes:

> Andrew Stubbs <ams@codesourcery.com> writes:
>
>> + /* Detect bad debug info. */
>> + maxsize = -offset;
>> + for (i = regnum; i < gdbarch_num_regs (gdbarch); i++)
>
> This is broken, it completely ignores the pseudo regs, which badly
> breaks ia64 and many other targets. Committed as obvious.
>
> Andreas.
>
> 2008-09-24 Andreas Schwab <schwab@suse.de>
>
> * frame.c (get_frame_register_bytes): Take pseudo registers into
> account.

Also checked this in to avoid useless function calls.

Andreas.

--- ChangeLog.~1.9844.~ 2008-09-24 14:15:35.000000000 +0200
+++ ChangeLog 2008-09-24 14:54:30.000000000 +0200
@@ -1,7 +1,7 @@
2008-09-24 Andreas Schwab <schwab@suse.de>

* frame.c (get_frame_register_bytes): Take pseudo registers into
- account.
+ account. Avoid excessive function calls.

2008-09-23 Doug Evans <dje@google.com>

--- frame.c.~1.254.~ 2008-09-24 14:09:33.000000000 +0200
+++ frame.c 2008-09-24 14:53:45.000000000 +0200
@@ -798,6 +798,7 @@ get_frame_register_bytes (struct frame_i
struct gdbarch *gdbarch = get_frame_arch (frame);
int i;
int maxsize;
+ int numregs;

/* Skip registers wholly inside of OFFSET. */
while (offset >= register_size (gdbarch, regnum))
@@ -809,8 +810,8 @@ get_frame_register_bytes (struct frame_i
/* Ensure that we will not read beyond the end of the register file.
This can only ever happen if the debug information is bad. */
maxsize = -offset;
- for (i = regnum;
- i < gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch); i++)
+ numregs = gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch);
+ for (i = regnum; i < numregs; i++)
{
int thissize = register_size (gdbarch, i);
if (thissize == 0)

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃŸe 5, 90409 NÃ¼rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."