From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3072 invoked by alias); 20 Apr 2010 05:38:59 -0000 Received: (qmail 3062 invoked by uid 22791); 20 Apr 2010 05:38:57 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SARE_MSGID_LONG45,SPF_HELO_PASS,TW_VX,TW_XG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 05:38:45 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id o3K5cgEl009098 for ; Tue, 20 Apr 2010 07:38:42 +0200 Received: from pzk36 (pzk36.prod.google.com [10.243.19.164]) by wpaz21.hot.corp.google.com with ESMTP id o3K5cexm013692 for ; Mon, 19 Apr 2010 22:38:41 -0700 Received: by pzk36 with SMTP id 36so27008pzk.24 for ; Mon, 19 Apr 2010 22:38:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.247.17 with HTTP; Mon, 19 Apr 2010 22:38:40 -0700 (PDT) In-Reply-To: References: <20100406215751.7EC1784397@ruffy.mtv.corp.google.com> Date: Tue, 20 Apr 2010 05:38:00 -0000 Received: by 10.141.108.9 with SMTP id k9mr5281626rvm.59.1271741920573; Mon, 19 Apr 2010 22:38:40 -0700 (PDT) Message-ID: Subject: Re: [RFA] Add -s option to source command. From: Doug Evans To: "H.J. Lu" Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0cd13a766bf86c0484a47d46 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00599.txt.bz2 --000e0cd13a766bf86c0484a47d46 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1751 On Sat, Apr 17, 2010 at 8:19 AM, H.J. Lu wrote: >> 2010-04-06 =A0Doug Evans =A0 >> >> =A0 =A0 =A0 =A0Add -s option to source command. >> =A0 =A0 =A0 =A0* cli/cli-cmds.c (find_and_open_script): Add function com= ment. >> =A0 =A0 =A0 =A0Delete from_tty and cleanupp args. =A0Split filep arg int= o file and >> =A0 =A0 =A0 =A0full_pathp. =A0New arg search_path. >> =A0 =A0 =A0 =A0(source_script_from_stream): New function. >> =A0 =A0 =A0 =A0(source_script_with_search): New function. >> =A0 =A0 =A0 =A0(source_script): Rewrite. >> =A0 =A0 =A0 =A0(source_command): Parse "-s" option. >> =A0 =A0 =A0 =A0(init_cli_cmds): Add "-s" docs to source command help. >> =A0 =A0 =A0 =A0* python/python.c (source_python_script): Make file arg a= const char *. >> =A0 =A0 =A0 =A0Don't call fclose, leave for caller. >> =A0 =A0 =A0 =A0* python/python.h (source_python_script): Update. >> >> =A0 =A0 =A0 =A0testsuite/ >> =A0 =A0 =A0 =A0* gdb.base/source-test.gdb: New file. >> =A0 =A0 =A0 =A0* gdb.base/source.exp: Add tests for "source -v" and "sou= rce -s". >> >> =A0 =A0 =A0 =A0doc/ >> =A0 =A0 =A0 =A0* gdb.texinfo (Command Files): Add docs for new "source -= s" option. >> > > This caused: > > help source^M > Read commands from a file named FILE.^M > ^M > Usage: source [-s] [-v] FILE^M > -s: search for the script in the source search path,^M > =A0 =A0even if FILE contains directories.^M > -v: each command in FILE is echoed as it is executed.^M > ^M > Note that the file ".gdbinit" is read automatically in this way^M > when GDB is started.^M > (gdb) FAIL: gdb.base/help.exp: help source Thanks. Fix checked in. 010-04-19 Doug Evans * gdb.base/help.exp (help source): Update expected output. --000e0cd13a766bf86c0484a47d46 Content-Type: text/plain; charset=US-ASCII; name="help-1.patch.txt" Content-Disposition: attachment; filename="help-1.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g88aadku0 Content-length: 2026 MjAxMC0wNC0xOSAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog Z2RiLmJhc2UvaGVscC5leHAgKGhlbHAgc291cmNlKTogVXBkYXRlIGV4cGVj dGVkIG91dHB1dC4KCkluZGV4OiBnZGIuYmFzZS9oZWxwLmV4cAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9oZWxwLmV4cCx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4zOApkaWZmIC11IC1wIC1yMS4zOCBoZWxwLmV4cAotLS0gZ2RiLmJh c2UvaGVscC5leHAJNCBBcHIgMjAxMCAyMzo0NzoxNiAtMDAwMAkxLjM4Cisr KyBnZGIuYmFzZS9oZWxwLmV4cAkyMCBBcHIgMjAxMCAwNTozNToyMCAtMDAw MApAQCAtNjA2LDcgKzYwNiw5IEBAIGdkYl90ZXN0ICJoZWxwIHN0ZXBpIiAi U3RlcCBvbmUgaW5zdHJ1Y3QKIGdkYl90ZXN0ICJoZWxwIHNpZ25hbCIgIkNv bnRpbnVlIHByb2dyYW0gZ2l2aW5nIGl0IHNpZ25hbC4qIiAiaGVscCBzaWdu YWwiCiAjIHRlc3QgaGVscCBzb3VyY2UKICMgdnhnZGIgcmVhZHMgLnZ4Z2Ri aW5pdAotZ2RiX3Rlc3QgImhlbHAgc291cmNlIiAiUmVhZCBjb21tYW5kcyBm cm9tIGEgZmlsZSBuYW1lZCBGSUxFXC5cW1xyXG5cXStPcHRpb25hbCAtdiBz d2l0Y2ggXFwoYmVmb3JlIHRoZSBmaWxlbmFtZVxcKSBjYXVzZXMgZWFjaCBj b21tYW5kIGluXFtcclxuXF0rRklMRSB0byBiZSBlY2hvZWQgYXMgaXQgaXMg ZXhlY3V0ZWRcLlxbXHJcblxdK05vdGUgdGhhdCB0aGUgZmlsZSBcIlxbXlwi XF0qXCIgaXMgcmVhZCBhdXRvbWF0aWNhbGx5IGluIHRoaXMgd2F5XFtcclxu XF0rd2hlbiBHREIgaXMgc3RhcnRlZFwuIiAiaGVscCBzb3VyY2UiCisjICIu LXMuIC4tdi4iIGlzIHdyaXR0ZW4gdGhhdCB3YXkgdG8gYXZvaWQgdGhlIGNv bXBsaWNhdGlvbnMgb2YgdHJ5aW5nCisjIHRvIGdldCAiWy1zXSBbLXZdIiB0 aHJvdWdoIGV4cGVjdCBhbmQgdGNsLgorZ2RiX3Rlc3QgImhlbHAgc291cmNl IiAiUmVhZCBjb21tYW5kcyBmcm9tIGEgZmlsZSBuYW1lZCBGSUxFXC5cW1xy XG5cXStVc2FnZTogc291cmNlIC4tcy4gLi12LiBGSUxFXFtcclxuXF0rLXM6 IHNlYXJjaCBmb3IgdGhlIHNjcmlwdCBpbiB0aGUgc291cmNlIHNlYXJjaCBw YXRoLFxbXHJcblxdK1xbIFxdK2V2ZW4gaWYgRklMRSBjb250YWlucyBkaXJl Y3Rvcmllc1wuXFtcclxuXF0rLXY6IGVhY2ggY29tbWFuZCBpbiBGSUxFIGlz IGVjaG9lZCBhcyBpdCBpcyBleGVjdXRlZFwuXFtcclxuXF0rTm90ZSB0aGF0 IHRoZSBmaWxlIFwiXFteXCJcXSpcIiBpcyByZWFkIGF1dG9tYXRpY2FsbHkg aW4gdGhpcyB3YXlcW1xyXG5cXSt3aGVuIEdEQiBpcyBzdGFydGVkXC4iICJo ZWxwIHNvdXJjZSIKICMgdGVzdCBoZWxwIHN0YWNrCiB0ZXN0X2NsYXNzX2hl bHAgInN0YWNrIiB7CiAgICAgIkV4YW1pbmluZyB0aGUgc3RhY2tcLi4qXFtc clxuXF0rIgo= --000e0cd13a766bf86c0484a47d46--