From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Make source_file_name const char *.
Date: Wed, 07 Apr 2010 16:56:00 -0000 [thread overview]
Message-ID: <j2me394668d1004070956ma1309f5cj4b500edfe050cc87@mail.gmail.com> (raw)
In-Reply-To: <20100407053308.GH19194@adacore.com>
On Tue, Apr 6, 2010 at 10:33 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I will check this patch in in a few days if there are no objections.
>> It just adds const to source_file_name.
>
> I'd say go ahead. I think your patch is an improvement, and at worst,
> it's so easy to revert that it's not worth the pain of waiting
> for potential objections (IMO).
"works for me"
Thanks, checked in.
prev parent reply other threads:[~2010-04-07 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 19:48 Doug Evans
2010-04-07 5:33 ` Joel Brobecker
2010-04-07 16:56 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j2me394668d1004070956ma1309f5cj4b500edfe050cc87@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox