From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XvjLGbtDiWeEUhEAWB0awg (envelope-from ) for ; Thu, 16 Jan 2025 12:36:59 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=zetier.com header.i=@zetier.com header.a=rsa-sha256 header.s=gm header.b=aEkV8N0M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A4F71E100; Thu, 16 Jan 2025 12:36:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 266BA1E05C for ; Thu, 16 Jan 2025 12:36:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB368384D194 for ; Thu, 16 Jan 2025 17:36:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB368384D194 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=zetier.com header.i=@zetier.com header.a=rsa-sha256 header.s=gm header.b=aEkV8N0M Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id EA264384DD00 for ; Thu, 16 Jan 2025 17:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA264384DD00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=zetier.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zetier.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA264384DD00 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::72b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737048976; cv=none; b=b/pwSt1Qea9oIW/otLxCpbzSpn/m5+2ALwVy133iuFW65+phQikk2cx2FfDQvI9ogD/jDKcU+9tBfuBMhdUYCJR9ldTR+RdwKhO0ABifDoShZAJ/vvwTQHLioLopctkrHtlYL5fHYOkM0KwSWNu++d0w72tOFOaim8GrHAD4tqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737048976; c=relaxed/simple; bh=ccjSFhhBteRXzoVsM0N2pfXifYy68nkx9AVrLl75pm8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wkoevoRjojxIFksGsqJMjjZP1t/roAFiYMMzJ123tWR4NY2jyZjH7rWEg9Pol6hJ9ns9eVI6U/GtqcmDIin3Ge1/EmsevVX4yfxTeRsUYI7lPzaZYyGRMKnUg5kZiaD6gtjGFoyVLbbUVkIMmfRdq98upk2aIbHIUshO+CVNSEA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA264384DD00 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7b6f95d2eafso124445085a.3 for ; Thu, 16 Jan 2025 09:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zetier.com; s=gm; t=1737048975; x=1737653775; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pfo6+rj1YP18IoUAQWB7fhIlzstJFJMR2FQGfBQMk60=; b=aEkV8N0MEg1I45ESpylwAo5PEWnLTjsyvVb5jLDpjow/t29XEY1KF0lNt1v1LBlPfP famtmQe+KOdfUOxvyvBMLEn7xhOJlijmou7pUK9n9QXIWucFVxwmUv0k8QM4Tb9GVRQc tmAwNrXboWDumUOGIRbx1ZUHHA3t7Wpp7knOEpeKj6TD5397oFALXgBUQYzmU3jsQ+pC 21PV3K2EbeK8LmXzwqiakPEmpJxpr+QKRllxh5oE49+GDd6bKnehwIjQGQOO/WAQ8aY5 OK5EoaFds/PYoSTSXzeK2t/e2bWXMavIDneiz4ZAqNtscNqdy4p3u2XOwAKOh7ox8gEq qwtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737048975; x=1737653775; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pfo6+rj1YP18IoUAQWB7fhIlzstJFJMR2FQGfBQMk60=; b=PhZ7XmNMxtulidaUJV6+ApPWi9+8AkmL9fubGitABZsLQcT98G7HUDCkXHu/v1s+2p uvraATzhigYo9HEqXrP2t5SGWpYyF/NEmTQcvIXrBhMz5MWiwIbz7VkdUYAzFGjZokst tUt/jjVroliG/V5BtY/KvNCrt6pS+kHtH9Z3sdGDh8woS0TMD4jyOjn/RNKZVisldDIL W0t4F6XqB4hY391o6PSnkGsYY607T9AuHHpOpHgQ7VWrXK6QjI4iy0uyV0pV/+OWhppN 93ZLFNgt+0ng+8BqmZ5fYusdqASx6TkqoEZ4QSZ7oNpNWZUtwT2VJHqKZT+Dc/beWIQp VyIg== X-Gm-Message-State: AOJu0YyNFSMdwzoYjTGnu5aU0IryRPiAbuy+JD5OZvOj7gaPHFNNcixf CeGJaFvJkMb8px+dG8IlC0B05KEzOzafFf5Vg+2ufhhUizi0hbE6BMMT/XsaJrjoB4cZQSaIO39 tsB4= X-Gm-Gg: ASbGncv0gJme9I6tQbW7H9t5Vebzjts92KfBcV/sXA24Fxks2WLpzV8jSxe20gDB0T3 TtZFF97qPVNDcoA7Ey20VV9BJKPrAqH1dehk/fktAgecHg2pagGugLRQQDG023TPkj5Dx1Smiar o+f1kQPbRnJeYw3jDclJVJw1DS2R7vCw9974EuLgM5HRtdg7QHNOjqFnCQBLElA1vMcvHxx6gze ahA2egNq6ryKZ8/jiP2C8nLklTnfUgEVwt5G+lfBEiBh0keakuH/wAnZuzoaXHSStcLP0+gjg== X-Google-Smtp-Source: AGHT+IFLxLIv5O2H3M75K/4VewW9tncpNYvp/1dU2P1BmQLlX6J+6WDa9ST1ZZ9nZKnS2JBnqiSA7w== X-Received: by 2002:a05:620a:d96:b0:7b6:ecaa:9638 with SMTP id af79cd13be357-7bcd97ada73mr5906773785a.55.1737048975046; Thu, 16 Jan 2025 09:36:15 -0800 (PST) Received: from brandonb.zetier.com ([65.222.209.234]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be61473cb9sm25105085a.11.2025.01.16.09.36.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Jan 2025 09:36:14 -0800 (PST) From: Brandon Belew To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails In-Reply-To: <87v7ueog73.fsf@redhat.com> (Andrew Burgess's message of "Thu, 16 Jan 2025 16:51:12 +0000") References: <87v7ueog73.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 16 Jan 2025 12:36:14 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Andrew Burgess writes: > I think you should reconsider here. The function returns LONGEST, so > that's what should be used. GDB's general policy is to fix little > bugs like this as the code gets touched for other reasons. Thanks Andrew! I'll go back and look at the LONGEST return value and get back to you on that with an updated patch. To be clear, you want the other function that was already using ssize_t for the return fixed as well?=20 > Otherwise, I agree with Luis, this looks great. If you repost with the > description in the commit message we can get this merged. I replied to Luis' message with some further questions about formatting. For reference, my original reply has a Message-ID of hwjgya7c6ulo46.fsf@brandonb.zetier.com. I'll redo those questions here: It was my understanding of git-format-patch / git-send-email (and in reverse, git-am) that the commit message would be taken from everything up to the '---'. Then everything between the '---' and the actual diff was considered "timely commentary" and would not be present in the commit message. This typically contains the diffstat output but also is used for commentary on the patch that shouldn't go into the commit itself. As described in https://git-scm.com/docs/git-format-patch: > Typically it will be placed in a MUA=E2=80=99s drafts folder, edited to a= dd > timely commentary that should not go in the changelog ***after the > three dashes*** [emphasis added]=20 And also as described at https://spacekookie.de/blog/collaborating-with-git-send-email/: > Another often overlooked feature here is "timely commentary", are > comments in the patch e-mail that won't be part of the patch or the > commit message itself. They can be made after the --- marker in a > patch mail, but before the actual patch starts. This section is > usually used for the diff-stat of that particular patch. I tried sending the patch email to myself before I sent it to the list, piping it to `git-am`, and it correctly applied the commit without my "timely commentary", so I was pretty convinced I had formatted it correctly. Do you get something different when you `git am` my message? If so, can you be more specific about how I need to reformat the email? Thanks! ~Brandon=20