From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18330 invoked by alias); 13 May 2002 16:43:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18323 invoked from network); 13 May 2002 16:43:40 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 13 May 2002 16:43:40 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id 7EB4F1E06F for ; Mon, 13 May 2002 18:43:39 +0200 (MEST) X-Authentication-Warning: gee.suse.de: aj set sender to aj@suse.de using -f To: Michal Ludvig Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Dwarf2 fix References: <3CDFEA7C.7050104@suse.cz> From: Andreas Jaeger Date: Mon, 13 May 2002 09:43:00 -0000 In-Reply-To: <3CDFEA7C.7050104@suse.cz> (Michal Ludvig's message of "Mon, 13 May 2002 18:31:56 +0200") Message-ID: User-Agent: Gnus/5.090007 (Oort Gnus v0.07) XEmacs/21.4 (Artificial Intelligence, i386-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-05/txt/msg00472.txt.bz2 Michal Ludvig writes: > Hi all, > this simple patch mysteriously solves problems that we have had on > x86-64 with stack unwinding. Can I commit? I believe so :-) What about committing to the 5.2 branch? Is a 5.2.1 planned? > > 2002-05-13 Michal Ludvig > * dwarf2cfi.c (context_cpy): Copy registers correctly. > (update_context): Use __func__ in notes. > > Index: dwarf2cfi.c > =================================================================== > RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v > retrieving revision 1.4 > diff -c -3 -p -r1.4 dwarf2cfi.c > *** dwarf2cfi.c 7 May 2002 11:22:54 -0000 1.4 > --- dwarf2cfi.c 13 May 2002 16:24:00 -0000 > *************** static void > *** 318,325 **** > --- 318,329 ---- > context_cpy (struct context *dst, struct context *src) > { > int regs_size = sizeof (struct context_reg) * NUM_REGS; > + struct context_reg *dreg; > > + dreg = dst->reg; > *dst = *src; > + dst->reg = dreg; > + Can you add a comment here, why this is needed? > memcpy (dst->reg, src->reg, regs_size); > } >[...] Thanks, Andreas -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.inka.de http://www.suse.de/~aj