Re: [RFA] Dwarf2CFI fix

Michal Ludvig
2003-02-26T22:07:40Z

Daniel Jacobowitz wrote:

> Either you're missing a bit of a patch or you're missing a bit of a
> changelog. And there's no changelog entry for struct eh_frame either.

Oops, sorry. The changelog wasn't yet saved while I was sending the mail...

Here it goes:

2003-02-26 Michal Ludvig <mludvig@suse.cz>

* dwarf2cfi.c (struct cie_unit): Added eh_frame field.
(parse_frame_info): It's not true that FDEs always refer to
the last CIE. We must deal with such a situation.

>>diff -upr gdb-upto-08/dwarf2cfi.c gdb/dwarf2cfi.c
>>--- gdb-upto-08/dwarf2cfi.c 2003-02-26 10:20:02.000000000 +0100
>>+++ gdb/dwarf2cfi.c 2003-02-26 17:17:30.000000000 +0100
>>@@ -50,6 +50,10 @@ struct cie_unit
>> char *data;
>> unsigned int data_length;
>>
>>+ /* This field is 1 for CIE from .eh_frame
>>+ and 0 for one from .debug_frame. */
>
>
> Formatting: don't wrap that early, and two spaces after a period.

OK, I'll reindent it with gdb_indent.sh before committing.

> The patch itself looks OK.

Is this an approval? :-)