From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9638 invoked by alias); 6 Nov 2009 17:25:17 -0000 Received: (qmail 9627 invoked by uid 22791); 6 Nov 2009 17:25:17 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Nov 2009 17:25:13 +0000 Received: from list by lo.gmane.org with local (Exim 4.50) id 1N6SYf-0002xW-5W for gdb-patches@sources.redhat.com; Fri, 06 Nov 2009 18:25:09 +0100 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Nov 2009 18:25:09 +0100 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Nov 2009 18:25:09 +0100 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [m68k] correct m68k_convert_register_p for coldfire Date: Fri, 06 Nov 2009 17:25:00 -0000 Message-ID: References: <200911061604.18419.vladimir@codesourcery.com> <200911061323.53556.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2953101.HdINrpJOt8" Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00113.txt.bz2 --nextPart2953101.HdINrpJOt8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit Content-length: 757 Pedro Alves wrote: > On Friday 06 November 2009 13:04:18, Vladimir Prus wrote: >> Index: gdb/m68k-tdep.c >> =================================================================== >> --- gdb/m68k-tdep.c     (revision 219692) >> +++ gdb/m68k-tdep.c     (revision 219693) >> @@ -177,7 +177,7 @@ >> if (!gdbarch_tdep (gdbarch)->fpregs_present) >> return 0; >> return (regnum >= M68K_FP0_REGNUM && regnum <= M68K_FP0_REGNUM + 7 >> -         && type != builtin_type_m68881_ext); >> +         && type != register_type (current_gdbarch, M68K_FP0_REGNUM)); >> } >> > > Please don't apply this as is without at least trying to > build it... current_gdbarch doesn't exist anymore. Doh! Here's what I've ended up checking it. - Volodya --nextPart2953101.HdINrpJOt8 Content-Type: text/x-diff; name="final.diff" Content-Transfer-Encoding: 8Bit Content-Disposition: attachment; filename="final.diff" Content-length: 1310 Index: gdb/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.11036 diff -u -p -r1.11036 ChangeLog --- gdb/ChangeLog 6 Nov 2009 14:26:09 -0000 1.11036 +++ gdb/ChangeLog 6 Nov 2009 17:21:57 -0000 @@ -1,5 +1,11 @@ 2009-11-06 Vladimir Prus + * m68k-tdep.c (m68k_convert_register_p): Compare with + the actual type of fp registers, not one of the possible + values. + +2009-11-06 Vladimir Prus + Prevent program output from mix with "^running". gdb/ Index: gdb/m68k-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/m68k-tdep.c,v retrieving revision 1.145 diff -u -p -r1.145 m68k-tdep.c --- gdb/m68k-tdep.c 7 Sep 2009 17:52:41 -0000 1.145 +++ gdb/m68k-tdep.c 6 Nov 2009 17:21:57 -0000 @@ -192,7 +192,8 @@ m68k_convert_register_p (struct gdbarch if (!gdbarch_tdep (gdbarch)->fpregs_present) return 0; return (regnum >= M68K_FP0_REGNUM && regnum <= M68K_FP0_REGNUM + 7 - && type != m68881_ext_type (gdbarch)); + && type != m68881_ext_type (gdbarch) + && type != register_type (gdbarch, M68K_FP0_REGNUM)); } /* Read a value of type TYPE from register REGNUM in frame FRAME, and --nextPart2953101.HdINrpJOt8--