From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8895 invoked by alias); 10 Aug 2009 16:55:17 -0000 Received: (qmail 8886 invoked by uid 22791); 10 Aug 2009 16:55:17 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Aug 2009 16:55:11 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MaY9L-0002Zf-7F for gdb-patches@sources.redhat.com; Mon, 10 Aug 2009 16:55:07 +0000 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Aug 2009 16:55:07 +0000 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Aug 2009 16:55:07 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [patch] MI: Error out on -var-create invalid FRAME-ADDR Date: Mon, 10 Aug 2009 17:00:00 -0000 Message-ID: References: <20090810162949.GA9704@host0.dyn.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00143.txt.bz2 Jan Kratochvil wrote: > -      if (innermost_block && fi != NULL) > +      if (innermost_block) > { > +         /* User could specify explicit FRAME-ADDR which was not found but > +            EXPRESSION is frame specific and we would not be able to evaluate > +            it correctly next time.  With VALID_BLOCK set we must also set > +            FRAME and THREAD_ID.  */ > +         if (fi == NULL) > +           { > +             fprintf_unfiltered (gdb_stderr, "Failed to find the specified" > +                                 " frame.\n"); > +             return NULL; > +           } Why is this fprintf + NULL return, as opposed to error? Seems OK otherwise. - Volodya