From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21083 invoked by alias); 7 Aug 2009 12:51:15 -0000 Received: (qmail 21071 invoked by uid 22791); 7 Aug 2009 12:51:10 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Aug 2009 12:51:03 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MZOuM-00049T-Tc for gdb-patches@sources.redhat.com; Fri, 07 Aug 2009 12:50:55 +0000 Received: from mobius.qnx.com ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Aug 2009 12:50:54 +0000 Received: from aristovski by mobius.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Aug 2009 12:50:54 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: Re: [patch] -Wall patches Date: Fri, 07 Aug 2009 15:42:00 -0000 Message-ID: References: <4A7B49C0.5070702@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) In-Reply-To: <4A7B49C0.5070702@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00108.txt.bz2 Michael Snyder wrote: > Aleksandar Ristovski wrote: >> Hello, >> >> >> I have internally made changes necessary to get clean compile with >> -Wall compiler option. I tried to break down the patch to related >> files; I am intentionally not writing a changelog since most of the >> changes are mechanical and consist of removing unused variables, >> several unused functions, gdb_byte/char casting. >> >> I would not mind if respective maintainers looked at the patches for >> their files and committed the changes (otherwise it will be quite >> cumbersome and somewhat overwhelming for me to keep the patch >> applicable; not to mention change log and all). > > Your change subsumes the change that I submitted to remove > unused variables from remote.c -- I'll hold off committing > that change 'till we decide what to do about it. > > Michael > I would suggest that you commit your changes, and just let me know here that a patch from my list is not relevant any more. E.g. "Wall-remote.diff not applicable any more". There is also Wall-tracepoint.diff which is in your domain too. I am not eager to commit all that myself, nor to seek credit, it is only trivial cleanup, but I would like to see gdb compile with -Wall and no warnings. Thanks, -- Aleksandar Ristovski QNX Software Systems