From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24931 invoked by alias); 10 Apr 2010 15:46:13 -0000 Received: (qmail 24921 invoked by uid 22791); 10 Apr 2010 15:46:11 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Apr 2010 15:46:06 +0000 Received: by vws15 with SMTP id 15so756303vws.0 for ; Sat, 10 Apr 2010 08:46:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.44.198 with HTTP; Sat, 10 Apr 2010 08:46:04 -0700 (PDT) In-Reply-To: <201004101449.o3AEnQO3004027@glazunov.sibelius.xs4all.nl> References: <20100409155012.GA19118@intel.com> <201004091559.o39FxnQi005865@glazunov.sibelius.xs4all.nl> <201004091915.o39JFfFN011160@glazunov.sibelius.xs4all.nl> <201004101449.o3AEnQO3004027@glazunov.sibelius.xs4all.nl> Date: Sat, 10 Apr 2010 15:46:00 -0000 Received: by 10.220.121.148 with SMTP id h20mr810579vcr.134.1270914364299; Sat, 10 Apr 2010 08:46:04 -0700 (PDT) Message-ID: Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE From: "H.J. Lu" To: Mark Kettenis Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00301.txt.bz2 On Sat, Apr 10, 2010 at 7:49 AM, Mark Kettenis wr= ote: >> Date: Fri, 9 Apr 2010 13:43:06 -0700 >> From: "H.J. Lu" >> >> On Fri, Apr 9, 2010 at 1:08 PM, H.J. Lu wrote: >> > On Fri, Apr 9, 2010 at 12:15 PM, Mark Kettenis wrote: >> >>> Date: Fri, 9 Apr 2010 09:01:01 -0700 >> >>> From: "H.J. Lu" >> >>> >> >>> On Fri, Apr 9, 2010 at 8:59 AM, Mark Kettenis wrote: >> >>> >> Date: Fri, 9 Apr 2010 08:50:12 -0700 >> >>> >> From: "H.J. Lu" >> >>> >> >> >>> >> Hi, >> >>> >> >> >>> >> This patch fixes gcore by not generating core regset sections whi= ch >> >>> >> aren't supported by i386 without SSE. =A0OK to install? >> >>> > >> >>> > Sorry, I think this is the wrong way to fix this. >> >>> > >> >>> >> >>> Any suggestions? >> >> >> >> Yup. =A0This makes sure we always install a list of register notes th= at >> >> matches the target description. >> >> >> >> 2010-04-09 =A0Mark Kettenis =A0 >> >> >> >> =A0 =A0 =A0 =A0* i386-linux-tdep.c (i386_linux_regset_sections): Remo= ve extended >> >> =A0 =A0 =A0 =A0register note sections. >> >> =A0 =A0 =A0 =A0(i386_linux_sse_regset_sections, i386_linux_avx_regset= _sections): >> >> =A0 =A0 =A0 =A0New variables. >> >> =A0 =A0 =A0 =A0(i386_linux_init_abi): Install list of supported regis= ter note >> >> =A0 =A0 =A0 =A0sections that matches the target description. >> >> >> > >> > That is nice. We should do the same thing in amd64-linux-tdep.c. >> > >> >> My second thought. No need to change amd64-linux-tdep.c. >> We can just add i386_linux_mmx_regset_sections. OK to install? > > Why should we do it this way? > It will be nice for "gcore" to generate all valid note sections so that the older gdb can still exam the core generated by the newer gdb even if the older gdb may not access the new registers it doesn't support. Otherwise, gdb 7.0 can't see any XMM registers in coredump generated by gdb 7.2 on AVX machine even if the upper 128bits of YMM registers are never used. --=20 H.J.