Re: [patch] gdbserver: Add support for Z0/Z1 packets

Pedro Alves
2009-06-24T19:28:01Z

On Wednesday 24 June 2009 20:19:55, Aleksandar Ristovski wrote:
> Your patch: Wasn't it more desireable to distinguish between
> (1) -unsupported and
> (-1)-error?
>
> i.e. in "default", shouldn't it be "res=-1" so that it makes
> it clear that gdb passed invalid argument?

Z0, Z1, Z2, etc. are different packets, the "type" is not
an argument to a Z packet. If we ever came up with a
Z8 packet, a gdbserver not recognizing it should reply
"unsupported", not error.

>
> Testsuite: I do run it but I admit sometimes not due to
> issues my system is giving me lately; I have to run tests
> "manually" i.e. one by one (I'll have to take some time to
> figure out why is the test run, after some time, just
> starting to ERROR, unable to properly spawn new gdb instance).

Okay, but there's always test with local gdbserver on linux or Windows
otherwise. It's really easy:

http://sourceware.org/gdb/wiki/Native_gdbserver_testing

--
Pedro Alves