From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Subject: [patch] nto target: code cleanup #2
Date: Thu, 11 Jun 2009 19:51:00 -0000 [thread overview]
Message-ID: <h0rn74$vve$1@ger.gmane.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
Hello,
Similar to the previous patch, removing unnecessary
indirections.
Thanks,
--
Aleksandar Ristovski
QNX Software Systems
ChangeLog:
* i386-nto-tdep.c (i386nto_init_abi): Remove nto_svr4_so_ops.
Initialize solib ops direcly and set them.
[-- Attachment #2: i386-nto-tdep.c-removento_svr4_so_ops-20090611.diff --]
[-- Type: text/x-patch, Size: 1937 bytes --]
Index: gdb/i386-nto-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-nto-tdep.c,v
retrieving revision 1.34
diff -u -p -r1.34 i386-nto-tdep.c
--- gdb/i386-nto-tdep.c 11 Jun 2009 19:29:00 -0000 1.34
+++ gdb/i386-nto-tdep.c 11 Jun 2009 19:49:53 -0000
@@ -322,7 +322,6 @@ static void
i386nto_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
- static struct target_so_ops nto_svr4_so_ops;
/* Deal with our strange signals. */
nto_initialize_signals ();
@@ -349,25 +348,16 @@ i386nto_init_abi (struct gdbarch_info in
set_solib_svr4_fetch_link_map_offsets
(gdbarch, svr4_ilp32_fetch_link_map_offsets);
- /* Initialize this lazily, to avoid an initialization order
- dependency on solib-svr4.c's _initialize routine. */
- if (nto_svr4_so_ops.in_dynsym_resolve_code == NULL)
- {
- nto_svr4_so_ops = svr4_so_ops;
-
- /* Our loader handles solib relocations differently than svr4. */
- nto_svr4_so_ops.relocate_section_addresses
- = nto_relocate_section_addresses;
-
- /* Supply a nice function to find our solibs. */
- nto_svr4_so_ops.find_and_open_solib
- = nto_find_and_open_solib;
-
- /* Our linker code is in libc. */
- nto_svr4_so_ops.in_dynsym_resolve_code
- = nto_in_dynsym_resolve_code;
- }
- set_solib_ops (gdbarch, &nto_svr4_so_ops);
+ /* Our loader handles solib relocations differently than svr4. */
+ svr4_so_ops.relocate_section_addresses = nto_relocate_section_addresses;
+
+ /* Supply a nice function to find our solibs. */
+ svr4_so_ops.find_and_open_solib = nto_find_and_open_solib;
+
+ /* Our linker code is in libc. */
+ svr4_so_ops.in_dynsym_resolve_code = nto_in_dynsym_resolve_code;
+
+ set_solib_ops (gdbarch, &svr4_so_ops);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
next reply other threads:[~2009-06-11 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 19:51 Aleksandar Ristovski [this message]
2009-06-15 14:17 ` Ulrich Weigand
2009-06-15 14:35 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h0rn74$vve$1@ger.gmane.org' \
--to=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox