From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4945 invoked by alias); 11 Jun 2009 19:16:20 -0000 Received: (qmail 4937 invoked by uid 22791); 11 Jun 2009 19:16:19 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 19:16:14 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MEpky-0005Yy-Ey for gdb-patches@sources.redhat.com; Thu, 11 Jun 2009 19:16:12 +0000 Received: from mobius.qnx.com ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Jun 2009 19:16:12 +0000 Received: from aristovski by mobius.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Jun 2009 19:16:12 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: [patch] nto target: Code cleanup Date: Thu, 11 Jun 2009 19:16:00 -0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020108020407050808040409" User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00312.txt.bz2 This is a multi-part message in MIME format. --------------020108020407050808040409 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 454 Hello, This patch removes i386_nto_target as unnecessary indirection. Thanks, -- Aleksandar Ristovski QNX Software Systems ChangeLog: * i386-nto-tdep.c (i386_nto_target): Remove definition. (init_i386nto_ops): Use macros to set fields to global current_nto_target directly. (i386nto_init_abi): Remove unused nto_set_target call. * nto-tdep.h (nto_set_target): Remove unused declaration. * nto-tdep.c (nto_set_target): Remove unused function. --------------020108020407050808040409 Content-Type: text/x-patch; name="i386-nto-tdep.c-removei386-nto-tdep-20090611.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="i386-nto-tdep.c-removei386-nto-tdep-20090611.diff" Content-length: 3174 Index: gdb/i386-nto-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-nto-tdep.c,v retrieving revision 1.33 diff -u -p -r1.33 i386-nto-tdep.c --- gdb/i386-nto-tdep.c 11 Jun 2009 17:12:11 -0000 1.33 +++ gdb/i386-nto-tdep.c 11 Jun 2009 19:12:33 -0000 @@ -34,9 +34,6 @@ #include "solib.h" #include "solib-svr4.h" -/* Target vector for QNX NTO x86. */ -static struct nto_target_ops i386_nto_target; - #ifndef X86_CPU_FXSR #define X86_CPU_FXSR (1L << 12) #endif @@ -310,14 +307,14 @@ i386nto_sigcontext_addr (struct frame_in static void init_i386nto_ops (void) { - i386_nto_target.regset_id = i386nto_regset_id; - i386_nto_target.supply_gregset = i386nto_supply_gregset; - i386_nto_target.supply_fpregset = i386nto_supply_fpregset; - i386_nto_target.supply_altregset = nto_dummy_supply_regset; - i386_nto_target.supply_regset = i386nto_supply_regset; - i386_nto_target.register_area = i386nto_register_area; - i386_nto_target.regset_fill = i386nto_regset_fill; - i386_nto_target.fetch_link_map_offsets = + nto_regset_id = i386nto_regset_id; + nto_supply_gregset = i386nto_supply_gregset; + nto_supply_fpregset = i386nto_supply_fpregset; + nto_supply_altregset = nto_dummy_supply_regset; + nto_supply_regset = i386nto_supply_regset; + nto_register_area = i386nto_register_area; + nto_regset_fill = i386nto_regset_fill; + nto_fetch_link_map_offsets = svr4_ilp32_fetch_link_map_offsets; } @@ -371,8 +368,6 @@ i386nto_init_abi (struct gdbarch_info in = nto_in_dynsym_resolve_code; } set_solib_ops (gdbarch, &nto_svr4_so_ops); - - nto_set_target (&i386_nto_target); } /* Provide a prototype to silence -Wmissing-prototypes. */ Index: gdb/nto-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/nto-tdep.h,v retrieving revision 1.14 diff -u -p -r1.14 nto-tdep.h --- gdb/nto-tdep.h 7 Jun 2009 17:58:24 -0000 1.14 +++ gdb/nto-tdep.h 11 Jun 2009 19:12:33 -0000 @@ -142,8 +142,6 @@ typedef struct _debug_regs void nto_init_solib_absolute_prefix (void); -void nto_set_target(struct nto_target_ops *); - char **nto_parse_redirection (char *start_argv[], const char **in, const char **out, const char **err); Index: gdb/nto-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/nto-tdep.c,v retrieving revision 1.32 diff -u -p -r1.32 nto-tdep.c --- gdb/nto-tdep.c 22 May 2009 23:49:13 -0000 1.32 +++ gdb/nto-tdep.c 11 Jun 2009 19:12:33 -0000 @@ -67,19 +67,6 @@ nto_target (void) #endif } -void -nto_set_target (struct nto_target_ops *targ) -{ - nto_regset_id = targ->regset_id; - nto_supply_gregset = targ->supply_gregset; - nto_supply_fpregset = targ->supply_fpregset; - nto_supply_altregset = targ->supply_altregset; - nto_supply_regset = targ->supply_regset; - nto_register_area = targ->register_area; - nto_regset_fill = targ->regset_fill; - nto_fetch_link_map_offsets = targ->fetch_link_map_offsets; -} - /* Take a string such as i386, rs6000, etc. and map it onto CPUTYPE_X86, CPUTYPE_PPC, etc. as defined in nto-share/dsmsgs.h. */ int --------------020108020407050808040409--