From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1848 invoked by alias); 5 Jun 2009 18:36:02 -0000 Received: (qmail 1839 invoked by uid 22791); 5 Jun 2009 18:36:02 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Jun 2009 18:35:54 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MCeGb-0002dH-48 for gdb-patches@sources.redhat.com; Fri, 05 Jun 2009 18:35:49 +0000 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 18:35:48 +0000 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 18:35:48 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [MI][Patch] -exec-continue/interrupt --thread-group expects wrong id Date: Fri, 05 Jun 2009 18:36:00 -0000 Message-ID: References: <6D19CA8D71C89C43A057926FE0D4ADAA0789E1B2@ecamlmw720.eamcs.ericsson.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2208451.8HfUZkeGaD" Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00107.txt.bz2 --nextPart2208451.8HfUZkeGaD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit Content-length: 682 Marc Khouzam wrote: > Hi, > > After Pedro kindly pointed out that there is a > --thread-group parameter to -exec-continue and -exec-interrupt > (how did I miss that?) I tried them out. > I found that they still expect the old form of the > threadGroupId (starting with a 'p'). > > The patch below fixes both methods. > > This is hard to test since HEAD does not have a fully functional > multi-process, but I was able to confirm that the threadGroupId > gets properly accepted with my patch. Thanks, I have applied this patch as attached. Please include changelog entry for future patch submissions though -- somebody still has to write them before "cvs commit" :-) - Volodya --nextPart2208451.8HfUZkeGaD Content-Type: text/x-diff; name="final.diff" Content-Transfer-Encoding: 8Bit Content-Disposition: attachment; filename="final.diff" Content-length: 1545 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.10553 diff -u -p -r1.10553 ChangeLog --- ChangeLog 5 Jun 2009 18:08:52 -0000 1.10553 +++ ChangeLog 5 Jun 2009 18:33:36 -0000 @@ -1,3 +1,9 @@ +2009-06-05 Marc Khouzam + + * mi/mi-main.c (mi_cmd_exec_continue) + (mi_cmd_exec_interrupt): Adjust parsing of thread group + ids to current reality, where they don't have any 'p' prefix. + 2009-06-05 Aleksandar Ristovski * corelow.c (core_open): Check for core_gdbarch before calling Index: mi/mi-main.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-main.c,v retrieving revision 1.149 diff -u -p -r1.149 mi-main.c --- mi/mi-main.c 28 May 2009 01:09:20 -0000 1.149 +++ mi/mi-main.c 5 Jun 2009 18:33:37 -0000 @@ -205,7 +205,7 @@ mi_cmd_exec_continue (char *command, cha int pid; if (argv[1] == NULL || argv[1] == '\0') error ("Thread group id not specified"); - pid = atoi (argv[1] + 1); + pid = atoi (argv[1]); if (!in_inferior_list (pid)) error ("Invalid thread group id '%s'", argv[1]); @@ -260,7 +260,7 @@ mi_cmd_exec_interrupt (char *command, ch int pid; if (argv[1] == NULL || argv[1] == '\0') error ("Thread group id not specified"); - pid = atoi (argv[1] + 1); + pid = atoi (argv[1]); if (!in_inferior_list (pid)) error ("Invalid thread group id '%s'", argv[1]); --nextPart2208451.8HfUZkeGaD--