From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17143 invoked by alias); 4 May 2009 17:54:37 -0000 Received: (qmail 17127 invoked by uid 22791); 4 May 2009 17:54:35 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 May 2009 17:54:29 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1M12N0-0000DR-59 for gdb-patches@sources.redhat.com; Mon, 04 May 2009 17:54:26 +0000 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 May 2009 17:54:26 +0000 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 May 2009 17:54:26 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: RE: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change Date: Mon, 04 May 2009 17:54:00 -0000 Message-ID: References: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se> <18940.53928.936676.982399@totara.tehura.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00067.txt.bz2 Nick Roberts wrote: > Marc Khouzam writes: > > Below is the session. The testcase is part of my Eclipse > > regression testsuite and basically looks for the content > > of a variable name the same thing as a previous variable, > > which is part of a method named the same thing as where the > > previous variable was. You'll understand better from the code > > below :-) > > OK, I see this now. The failure occurs because `public' is considered > an unchangeable field by GDB. > > > Note that the below passes after I applied my proposed patch. > > As a general principle, if a regression occurs I try to remove some of the > added logic, rather than add to it, as I find the latter tends to make > the logic more convoluted. > > The procedure, varobj_update, used to return a scalar that corresponded to the > status field of the structure. varobj_update_result. I don't know what the > advantage of returning a vector of structures is but, in any case, the changed > field of varobj_update_result appears not to be used outside varobj_update. I > would suggest a change something like below. A full patch would remove the > changed field altogether. Can you post this as unified diff? I can't read context diffs at all :-( - Volodya