From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5250 invoked by alias); 2 Apr 2009 14:08:07 -0000 Received: (qmail 5225 invoked by uid 22791); 2 Apr 2009 14:08:04 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Apr 2009 14:08:00 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LpNaI-0006o1-GD for gdb-patches@sources.redhat.com; Thu, 02 Apr 2009 14:07:58 +0000 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Apr 2009 14:07:58 +0000 Received: from vladimir by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Apr 2009 14:07:58 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: Enable non-stop mode MI tests against remote targets. Date: Thu, 02 Apr 2009 14:08:00 -0000 Message-ID: References: <200903260054.52525.pedro@codesourcery.com> <200903260228.28983.pedro@codesourcery.com> <200904020023.31264.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00030.txt.bz2 Pedro Alves wrote: > On Thursday 26 March 2009 02:28:28, Pedro Alves wrote: >> On Thursday 26 March 2009 00:54:52, Pedro Alves wrote: >> > With this patch, the MI non-stop mode tests pass cleanly against >> > gdbserver once the gdbserver non-stop mode patch is applied: >> > >> > http://sourceware.org/ml/gdb-patches/2009-03/msg00582.html >> > >> > The tests currently assume a native GDB. They use -exec-run >> > directly. I've changed them to use mi_run_to_main, which >> > works nicelly. To make the tests fails fail gracefully when >> > the remote side doesn't support non-stop mode, I've made >> > mi_run_to_main and its callees propagate an error return up, >> > similarly to CLI's runto_main. This means that this patch can go >> > in before the gdbserver bits go in. Most other MI tests could be >> > adjusted to do the same "if { [mi_run_to_main] < 0 } { BAIL }" >> > check, which avoids cascasted FAILs and timeouts. >> > >> > Vladimir, do you think this looks OK? > > > Hi Vladimir, gdbserver now supports non-stop mode, so we need > to be able to test it. :-) Do you have any comments on > this approach? Thanks for asking. I think it's fine! - Volodya