From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch] Fix a value leak by VAROBJ
Date: Mon, 09 Mar 2009 22:33:00 -0000 [thread overview]
Message-ID: <gp44hg$mp8$1@ger.gmane.org> (raw)
In-Reply-To: <20090309182211.GA21666@host0.dyn.jankratochvil.net>
Jan Kratochvil wrote:
> Hi,
>
> a memory leak. install_new_value() already release_value()s `var->value'.
>
> No regressions on x86_64-unknown-linux-gnu (there is now a recent regression
> on HEAD for gdb.base/sigbpt.exp but it is unrelated to this patch).
>
>
> Thanks,
> Jan
>
>
> gdb/
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * varobj.c (free_variable): Call value_free.
>
> --- gdb/varobj.c 5 Feb 2009 17:28:21 -0000 1.123
> +++ gdb/varobj.c 9 Mar 2009 17:35:49 -0000
> @@ -1512,6 +1512,8 @@ new_root_variable (void)
> static void
> free_variable (struct varobj *var)
> {
> + value_free (var->value);
> +
> /* Free the expression if this is a root variable. */
> if (is_root_p (var))
> {
This is OK.
Thanks,
Volodya
next prev parent reply other threads:[~2009-03-09 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 18:22 Jan Kratochvil
2009-03-09 22:33 ` Vladimir Prus [this message]
2009-03-09 23:31 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gp44hg$mp8$1@ger.gmane.org' \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox