From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23528 invoked by alias); 6 Mar 2009 14:52:21 -0000 Received: (qmail 23520 invoked by uid 22791); 6 Mar 2009 14:52:20 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Mar 2009 14:52:13 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LfbPF-0001Zl-CC for gdb-patches@sources.redhat.com; Fri, 06 Mar 2009 14:52:09 +0000 Received: from mobius.qnx.com ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Mar 2009 14:52:09 +0000 Received: from aristovski by mobius.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Mar 2009 14:52:09 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: Re: [patch] mips-tdep: info registers Date: Fri, 06 Mar 2009 14:52:00 -0000 Message-ID: References: <20090227195607.GJ26056@adacore.com> <20090305191245.GB3744@adacore.com> <20090305192211.GA2342@caradoc.them.org> <20090305193512.GB3070@caradoc.them.org> <20090305225030.GD3744@adacore.com> <20090305230759.GA18795@caradoc.them.org> <49B0ADEF.8060807@qnx.com> <20090306122450.GA14439@caradoc.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010603020803080703070804" User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) In-Reply-To: <20090306122450.GA14439@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org X-SW-Source: 2009-03/txt/msg00080.txt.bz2 This is a multi-part message in MIME format. --------------010603020803080703070804 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 825 Daniel Jacobowitz wrote: > On Fri, Mar 06, 2009 at 12:00:31AM -0500, Aleksandar Ristovski wrote: >> Maybe adding gdbarch_regname_to_regnum or something like that (which would >> avoid iterating through the registers and comparing returned register >> names). > > Let's keep optimization separate from functionality; there's a > function in user-regs.h to do the lookup and if it's too slow it can > be converted to use a hash table. > I didn't really think about optimization, but I did not understand what/how user-regs is being used. Now I realize that is the mechanism for adding register aliases. Here is another try. (again, tested on in-house gdb variant). ChangeLog: * mips-tdep.c (mips_numeric_register_alieses): New definition. (mips_gdbarch_init): Add user registers from mips_numeric_register_aliases. --------------010603020803080703070804 Content-Type: text/x-patch; name="mips-tdep.c-numeric-register-names-20090306.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mips-tdep.c-numeric-register-names-20090306.diff" Content-length: 1242 Index: gdb/mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.490 diff -u -p -r1.490 mips-tdep.c --- gdb/mips-tdep.c 22 Feb 2009 01:02:17 -0000 1.490 +++ gdb/mips-tdep.c 6 Mar 2009 14:43:42 -0000 @@ -143,6 +143,15 @@ const struct register_alias mips_registe { "fsr", MIPS_EMBED_FP0_REGNUM + 32 } }; +const struct register_alias mips_numeric_register_aliases[] = { +#define R(n) { #n, n } + R(0), R(1), R(2), R(3), R(4), R(5), R(6), R(7), + R(8), R(9), R(10), R(11), R(12), R(13), R(14), R(15), + R(16), R(17), R(18), R(19), R(20), R(21), R(22), R(23), + R(24), R(25), R(26), R(27), R(28), R(29), R(30), R(31), +#undef R +}; + #ifndef MIPS_DEFAULT_FPU_TYPE #define MIPS_DEFAULT_FPU_TYPE MIPS_FPU_DOUBLE #endif @@ -6058,6 +6067,11 @@ mips_gdbarch_init (struct gdbarch_info i user_reg_add (gdbarch, mips_register_aliases[i].name, value_of_mips_user_reg, &mips_register_aliases[i].regnum); + for (i = 0; i < ARRAY_SIZE (mips_numeric_register_aliases); i++) + user_reg_add (gdbarch, mips_numeric_register_aliases[i].name, + value_of_mips_user_reg, + &mips_numeric_register_aliases[i].regnum); + return gdbarch; } --------------010603020803080703070804--