From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36959 invoked by alias); 18 Nov 2019 23:14:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36935 invoked by uid 89); 18 Nov 2019 23:14:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=minsym X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 23:14:31 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8F27620393; Mon, 18 Nov 2019 18:14:29 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5CB372013D; Mon, 18 Nov 2019 18:14:25 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 344752816F; Mon, 18 Nov 2019 18:14:25 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 18 Nov 2019 23:14:00 -0000 From: "Christian Biesinger (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Create a correctly-sized demangled names hashtable X-Gerrit-Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e X-Gerrit-Change-Number: 686 X-Gerrit-ChangeURL: X-Gerrit-Commit: b5f0fe2db448850c0d332a0cd644d36046d975ff References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2019-11/txt/msg00560.txt.bz2 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/686 ...................................................................... Create a correctly-sized demangled names hashtable If we have a minsym count, we know the demangled names hashtable will be at least that big. So use that count to create it, so we don't have to resize/rehash it as much. This is a 6% improvement in minsym loading time. 2019-11-18 Christian Biesinger * symtab.c (create_demangled_names_hash): Use per_bfd-> minimal_symbol_count as the initial size, if greater than our default size. Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e --- M gdb/symtab.c 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 3502827..e4da065 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -769,10 +769,17 @@ /* Choose 256 as the starting size of the hash table, somewhat arbitrarily. The hash table code will round this up to the next prime number. Choosing a much larger table size wastes memory, and saves only about - 1% in symbol reading. */ + 1% in symbol reading. However, if the minsym count is already + initialized (e.g. because symbol name setting was deferred to + a background thread) we can initialize the hashtable with that + count, because we will almost certainly have at least that + many entries. If we have a nonzero number but less than 256, + we still stay with 256 to have some space for psymbols, etc. */ + + int count = std::max (per_bfd->minimal_symbol_count, 256); per_bfd->demangled_names_hash.reset (htab_create_alloc - (256, hash_demangled_name_entry, eq_demangled_name_entry, + (count, hash_demangled_name_entry, eq_demangled_name_entry, free_demangled_name_entry, xcalloc, xfree)); } -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I1f074d38e1d90af58705ec852f90c84cc034cd2e Gerrit-Change-Number: 686 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-MessageType: newchange