From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14939 invoked by alias); 8 Nov 2019 16:22:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14930 invoked by uid 89); 8 Nov 2019 16:22:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=sal X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 16:22:29 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 66E7920C7E; Fri, 8 Nov 2019 11:22:27 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3000220322 for ; Fri, 8 Nov 2019 11:22:26 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 01AD825B28 for ; Fri, 8 Nov 2019 11:22:25 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 08 Nov 2019 16:22:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] gdb: Convert frame_show_address to return a bool X-Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f X-Gerrit-Change-Number: 541 X-Gerrit-ChangeURL: X-Gerrit-Commit: 15fd4ce2e03f60fbc58c933418a243ea238ab8ed References: Reply-To: andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2019-11/txt/msg00234.txt.bz2 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/541 ...................................................................... gdb: Convert frame_show_address to return a bool Just a clean up, should be no user visible changes after this commit. gdb/ChangeLog: * stack.c (frame_show_address): Convert return type to bool. * stack.h (frame_show_address): Likewise, and update header comment. Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f --- M gdb/ChangeLog M gdb/stack.c M gdb/stack.h 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f5c8a76..312eed7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-11-08 Andrew Burgess + + * stack.c (frame_show_address): Convert return type to bool. + * stack.h (frame_show_address): Likewise, and update header + comment. + 2019-11-08 Tom Tromey * top.c (read_command_file): Update. diff --git a/gdb/stack.c b/gdb/stack.c index fa057db..5af00c7 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -252,7 +252,7 @@ /* See stack.h. */ -int +bool frame_show_address (struct frame_info *frame, struct symtab_and_line sal) { @@ -267,7 +267,7 @@ gdb_assert (inline_skipped_frames (inferior_thread ()) > 0); else gdb_assert (get_frame_type (get_next_frame (frame)) == INLINE_FRAME); - return 0; + return false; } return get_frame_pc (frame) != sal.pc; diff --git a/gdb/stack.h b/gdb/stack.h index dda4fc9..28d2273 100644 --- a/gdb/stack.h +++ b/gdb/stack.h @@ -49,10 +49,10 @@ void get_user_print_what_frame_info (gdb::optional *what); -/* Return 1 if we should display the address in addition to the location, +/* Return true if we should display the address in addition to the location, because we are in the middle of a statement. */ -int frame_show_address (struct frame_info *frame, struct symtab_and_line sal); +bool frame_show_address (struct frame_info *frame, struct symtab_and_line sal); /* Get or set the last displayed symtab and line, which is, e.g. where we set a * breakpoint when `break' is supplied with no arguments. */ -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iaaa9ebd4ff6534db19c5329f1c604932c747bd7f Gerrit-Change-Number: 541 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-MessageType: newchange