From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14801 invoked by alias); 25 Oct 2019 18:42:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14793 invoked by uid 89); 25 Oct 2019 18:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN autolearn=ham version=3.3.1 spammy=psymtab X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 18:42:51 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A316421059; Fri, 25 Oct 2019 14:42:49 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5852E20EAD; Fri, 25 Oct 2019 14:42:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 30DC8204C9; Fri, 25 Oct 2019 14:42:48 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Fri, 25 Oct 2019 18:42:00 -0000 From: "Christian Biesinger (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange Subject: [review] Add static_asserts for the sizes of space-critical structs X-Gerrit-Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6 X-Gerrit-Change-Number: 306 X-Gerrit-ChangeURL: X-Gerrit-Commit: 51343b071dcc37eaad1b205231bde4e266b3bb86 References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2019-10/txt/msg00928.txt.bz2 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/306 ...................................................................... Add static_asserts for the sizes of space-critical structs Specifically the three structs mentioned in symtab.h: - general_symbol_info - symbol - partial_symbol This ensures that those structs won't accidentally get bigger. gdb/ChangeLog: 2019-10-25 Christian Biesinger * psympriv.h: Add static_asserts for sizeof (general_symbol_info) and sizeof (symbol). * symtab.h: Add a static_assert for sizeof (partial_symbol). Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6 --- M gdb/psympriv.h M gdb/symtab.h 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/gdb/psympriv.h b/gdb/psympriv.h index 3e89742..b32311c 100644 --- a/gdb/psympriv.h +++ b/gdb/psympriv.h @@ -81,6 +81,10 @@ ENUM_BITFIELD(address_class) aclass : SYMBOL_ACLASS_BITS; }; +gdb_static_assert ((sizeof (void *) == 8 && sizeof (partial_symbol) == 40) + || (sizeof (void *) == 4 && + sizeof (partial_symbol) == 24)); + /* A convenience enum to give names to some constants used when searching psymtabs. This is internal to psymtab and should not be used elsewhere. */ diff --git a/gdb/symtab.h b/gdb/symtab.h index dc65409..e02e49b 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -445,6 +445,10 @@ short section; }; +gdb_static_assert ((sizeof (void *) == 8 && sizeof (general_symbol_info) == 32) + || (sizeof (void *) == 4 && + sizeof (general_symbol_info) == 20)); + extern void symbol_set_demangled_name (struct general_symbol_info *, const char *, struct obstack *); @@ -1182,6 +1186,9 @@ struct symbol *hash_next; }; +gdb_static_assert ((sizeof (void *) == 8 && sizeof (symbol) == 72) || + (sizeof (void *) == 4 && sizeof (symbol) == 40)); + /* Several lookup functions return both a symbol and the block in which the symbol is found. This structure is used in these cases. */ -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Idd68320aa3e79ee7cc749019724636a58ce4b9c6 Gerrit-Change-Number: 306 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-MessageType: newchange