RE: [review v3] testsuite, cp: increase the coverage of testing pass-by-ref arguments

Aktemur, Tankut Baris
2020-01-15T14:30:48Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1797 bytes --]

On Tuesday, January 14, 2020 2:13 PM, Luis Machado wrote:
>
> On 1/14/20 9:52 AM, Aktemur, Tankut Baris wrote:
> >
> > I've investigated GCC and Clang for this. GCC started emitting DW_AT_deleted and
> > DW_AT_defaulted with version 7. Clang does not emit these attributes; however, it
> > has been emitting DW_AT_calling_convention starting with version 7. This
> > attribute helps the debugger make the right decision in some cases.
> >
> > Based on this, I think the test cases have to be filtered in a somewhat
> > fine-granular manner. Therefore I thought I could save you from the burden of
> > having to go through the code-generating test definition. Below is a patch proposal.
> >
> > -Baris
>
> Thanks! I've checked this on my box with an older GCC and i see the
> XFAIL's now. So it looks good to me.
>
> Small nit below...
>

Thank you. I'll fix that and wait for an official approval.

-Baris

> > +# GCC version <= 6 and Clang do not emit DW_AT_defaulted and DW_AT_deleted
> > +set is_gcc_6_or_older [test_compiler_info {gcc-[0-6]-*}]
> > +set is_clang [test_compiler_info {clang-*}]
> > +
> > set bp_location [gdb_get_line_number "stop here"]
> > gdb_breakpoint $bp_location
> > gdb_continue_to_breakpoint "end of main" ".*return .*;"
>
> It seems to be a mixed bag, but i see more examples of having a period
> after the sentence than not having it. Multiple cases of this on the patch.
>
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
\x16º&Öéj×!zÊÞ¶êç×­õÓ©b²Ö«r\x18\x1dn–­r\x17¬