From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10309 invoked by alias); 23 Jun 2008 08:52:47 -0000 Received: (qmail 10300 invoked by uid 22791); 23 Jun 2008 08:52:47 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Jun 2008 08:52:27 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KAhmf-0001Lr-1A for gdb-patches@sources.redhat.com; Mon, 23 Jun 2008 08:52:21 +0000 Received: from gate.lvk.cs.msu.su ([158.250.17.1]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 Jun 2008 08:52:21 +0000 Received: from vladimir by gate.lvk.cs.msu.su with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 23 Jun 2008 08:52:21 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [non-stop] 01/10 Add "executing" property Date: Mon, 23 Jun 2008 11:54:00 -0000 Message-ID: References: <200806152203.14626.pedro@codesourcery.com> <20080617055354.GA3803@adacore.com> <200806171924.04486.pedro@codesourcery.com> <20080623010353.GA23201@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00379.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Jun 17, 2008 at 07:24:04PM +0100, Pedro Alves wrote: >> @@ -422,7 +417,10 @@ execute_command (char *p, int from_tty) >> >> /* If the target is running, we allow only a limited set of >> commands. */ >> - if (target_can_async_p () && target_executing && !get_cmd_async_ok (c)) >> + if (target_can_async_p () >> + && target_has_execution >> + && any_running () >> + && !get_cmd_async_ok (c)) >> error (_("Cannot execute this command while the target is running.")); >> >> /* Pass null arg rather than an empty one. */ > > Don't need target_has_execution here anymore, do we? > > The patch otherwise looks OK. > > Before we start checking these in, how do you plan to handle > documentation (internals also, but mostly user) and test cases? Test cases are on my plate, FWIW, as well as MI docs. I'm not sure if there's general docs to be written, and I'm not not sure about internals docs. - Volodya