From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12161 invoked by alias); 11 Jun 2008 13:39:27 -0000 Received: (qmail 12058 invoked by uid 22791); 11 Jun 2008 13:39:26 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Jun 2008 13:39:06 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K6QXS-0004kZ-3K for gdb-patches@sources.redhat.com; Wed, 11 Jun 2008 13:38:58 +0000 Received: from 78.158.192.230 ([78.158.192.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Jun 2008 13:38:58 +0000 Received: from vladimir by 78.158.192.230 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 11 Jun 2008 13:38:58 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: mi-break.exp intermitent failure Date: Wed, 11 Jun 2008 14:07:00 -0000 Message-ID: References: <200806111259.13949.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart1719040.koupszLJNv" Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00222.txt.bz2 --nextPart1719040.koupszLJNv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8Bit Content-length: 961 Pedro Alves wrote: > Hi, > > I'm getting these intermitent FAILures in mi-break.exp (and a couple > more in chain reaction) in sync mode, due to previous pattern > considering the gdb prompt optional, hence sometimes consuming the > *stopped line, and leaving the (gdb) unconsumed. > > Running ../../../src/gdb/testsuite/gdb.mi/mi-break.exp ... > FAIL: gdb.mi/mi-break.exp: breakpoint at nonexistent function > FAIL: gdb.mi/mi-break.exp: create varobj for function call > FAIL: gdb.mi/mi-break.exp: update varobj for function call Thanks for reporting; somehow I never run into this. As I've told on IRC, the test should be using mi_expect_stop; I've no idea why I did not covert it when I've introduced mi_expect_stop but I've checked in the following patch. Can you check that no unexpected failures happen for you now. Incidentally, mi-async.exp is the only file that has direct checks for *stopped, but those will die very soon now. Thanks, Volodya --nextPart1719040.koupszLJNv Content-Type: text/x-diff; name="commit.diff" Content-Transfer-Encoding: 8Bit Content-Disposition: attachment; filename="commit.diff" Content-length: 1674 Index: gdb/testsuite/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.1661 diff -u -p -r1.1661 ChangeLog --- gdb/testsuite/ChangeLog 10 Jun 2008 10:23:54 -0000 1.1661 +++ gdb/testsuite/ChangeLog 11 Jun 2008 13:34:48 -0000 @@ -1,5 +1,9 @@ 2008-06-10 Vladimir Prus + * gdb.mi/mi-break.exp (test_ignore_count): Use mi_expect_stop. + +2008-06-10 Vladimir Prus + * gdb.mi/mi-console.exp: Adjust. * gdb.mi/mi-syn-frame.exp: Adjust. * gdb.mi/mi2-console.exp: Adjust. Index: gdb/testsuite/gdb.mi/mi-break.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-break.exp,v retrieving revision 1.18 diff -u -p -r1.18 mi-break.exp --- gdb/testsuite/gdb.mi/mi-break.exp 10 Jun 2008 09:35:08 -0000 1.18 +++ gdb/testsuite/gdb.mi/mi-break.exp 11 Jun 2008 13:34:48 -0000 @@ -158,17 +158,8 @@ proc test_ignore_count {} { mi_run_cmd - gdb_expect { - -re ".*\\*stopped.*func=\"callme\".*args=\\\[\{name=\"i\",value=\"2\"\}\\\].*\r\n($mi_gdb_prompt)?$" { - pass "run to breakpoint with ignore count" - } - -re ".*$mi_gdb_prompt$" { - fail "run to breakpoint with ignore count" - } - timeout { - fail "run to breakpoint with ignore count (timeout)" - } - } + mi_expect_stop "breakpoint-hit" "callme" "\{name=\"i\",value=\"2\"\}" ".*basics.c" "51" \ + {"" "disp=\"keep\"" } "run to breakpoint with ignore count" } proc test_error {} { --nextPart1719040.koupszLJNv--