From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21777 invoked by alias); 28 May 2008 16:25:52 -0000 Received: (qmail 21761 invoked by uid 22791); 28 May 2008 16:25:52 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 May 2008 16:25:32 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K1OSs-0007zr-2z for gdb-patches@sources.redhat.com; Wed, 28 May 2008 16:25:26 +0000 Received: from 78.158.192.230 ([78.158.192.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 May 2008 16:25:26 +0000 Received: from vladimir by 78.158.192.230 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 May 2008 16:25:26 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [patch/MI] Implementation for break-catch command Date: Wed, 28 May 2008 21:26:00 -0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.9 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00733.txt.bz2 Aleksandar Ristovski wrote: > Hello, > > The attached diff implements -break-catch command for MI protocol (includes the documentation > changes). > > Thanks, > > Aleksandar Ristovski > QNX Software Systems > > 2008-05-28 Aleksandar Ristovski > > * breakpoint.c (catch_command_1): Remove static declaration. > (print_mention_exception_catchpoint): Output information only > when non-MI protocol is active. > * breakpoint.h (catch_command_1): New declaration. > * doc/gdb.texinfo (break-catch): Remove @ignore and add text for > break-catch command. > * mi/mi-cmd-break.c (mi_cmd_break_catch): New function. This one accepts and parses a lot of options, and then ignores them. Some options, like -f, will never make any sense for -break-catch. Can you please only leave necessary code there? Also note that the condition is actually meaningful for catchpoints and catch_exception_command_1/handle_gnu_v3_exceptions actually tries to set condition. Should setting a condition via MI work too? > * mi/mi-cmds.c (build_table): Add function for break-catch. It's not build_table, it's mi_cmds. "diff -p" sometimes lies. - Volodya