From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4113 invoked by alias); 26 Apr 2008 10:55:54 -0000 Received: (qmail 4105 invoked by uid 22791); 26 Apr 2008 10:55:54 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 26 Apr 2008 10:55:35 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Jpi3w-0001Kk-L7 for gdb-patches@sources.redhat.com; Sat, 26 Apr 2008 10:55:24 +0000 Received: from 78.158.192.230 ([78.158.192.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 26 Apr 2008 10:55:24 +0000 Received: from vladimir by 78.158.192.230 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 26 Apr 2008 10:55:24 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [RFA] Remove command_line_handler_continuation. Date: Sat, 26 Apr 2008 13:24:00 -0000 Message-ID: References: <200804242033.40568.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00587.txt.bz2 Eli Zaretskii wrote: >> From: Vladimir Prus >> Date: Thu, 24 Apr 2008 19:33:40 +0300 >> >> >> With my previous patch to move all bpstat_do_actions calls into >> event handler, all that command_line_handler_continuation does >> is to print timings, if those are enabled. However, those timings >> don't make much sense. Timings are good for debugging GDB performance, >> and in case of command_line_handler_continuation, the times will report >> the time when the application run. >> >> So, this patch removes that continuation. OK? > > Doesn't this require some change to the manual, where these timings > are described? I can only find this bit in the manual: -statistics This option causes GDB to print statistics about time and memory usage after it completes each command and returns to the prompt. Is this what should be changed, or there's something else I've missed? - Volodya