From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1664 invoked by alias); 24 Apr 2008 04:41:48 -0000 Received: (qmail 1653 invoked by uid 22791); 24 Apr 2008 04:41:47 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Apr 2008 04:41:27 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JotGq-0000yS-IR for gdb-patches@sources.redhat.com; Thu, 24 Apr 2008 04:41:20 +0000 Received: from 78.158.192.230 ([78.158.192.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Apr 2008 04:41:20 +0000 Received: from vladimir by 78.158.192.230 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 24 Apr 2008 04:41:20 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [RFA] Keep breakpoints always inserted. Date: Thu, 24 Apr 2008 11:22:00 -0000 Message-ID: References: <200802281717.14766.vladimir@codesourcery.com> <20080417164157.GK17488@caradoc.them.org> <200804232045.55097.pedro@codesourcery.com> <20080423201007.GA14383@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00548.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Apr 23, 2008 at 08:45:54PM +0100, Pedro Alves wrote: >> I've tested this patch on top of Vladimir's and with displaced >> stepping on, on x86-pc-linux-gnu. Luis tested it on PPC, where >> it also fixed things. > > OK when the original patch is committed. Well, I have an obvious adjustment to the original patch to fix this issue in a more clear way -- my making should_insert_location not return false for an already inserted location. >> Anyone object to adding debug output support to the >> breakpoint module? I've writen something similar twice >> already, and I'd like to not have to a third time. Something >> like "set debug breakpoint 1", where it prints >> "breakpoints inserted", "breakpoints removed", etc. > > Sounds like a good idea to me. Likewise. - Volodya