Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Using bt command in async mode
Date: Thu, 10 Apr 2008 16:05:00 -0000	[thread overview]
Message-ID: <ftldhf$1v0$1@ger.gmane.org> (raw)
In-Reply-To: <18418.37659.924305.827404@kahikatea.snap.net.nz>

Nick Roberts wrote:

>  > Nick> This patch allows the bt to be executed in async mode while the
>  > Nick> inferior is executing.
>  > 
>  > Nick> !        && strcmp (c->name, "interrupt") != 0
>  > Nick> !        && strcmp (c->name, "bt") != 0)
>  > 
>  > I've seen a couple patches recently that touch this conditional.
>  > 
>  > What do you think of this?  It moves the flag into the command object
>  > instead of hard-coding it into a big 'if'.
> 
> Sure, the list will only get longer.  In the long run it might be a good
> idea to add an argument to add_cmd and related functions.
> 
> Incidentally, the patch I've presented for bt isn't suitable for inclusion
> as it uses:
> 
> +
> +   if (restart)
> +     continue_command ("&", 0);
> 
> If the user interrupts with 'bt' during a step, he presumably wants the step to
> finish.  I'm not sure how easy it is for Gdb to jump the inferior back into
> it's old state of execution.

It's not very hard. You only need to hack continue_command not to call (indirectly)
the clear_proceed_status function, which currently wipes away all state.

- Volodya



  reply	other threads:[~2008-04-10 16:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  2:08 Nick Roberts
2008-04-01 19:55 ` Tom Tromey
2008-04-01 22:30   ` Nick Roberts
2008-04-10 16:05     ` Vladimir Prus [this message]
2008-04-11 22:55       ` Nick Roberts
2008-04-10 15:22   ` Daniel Jacobowitz
2008-04-10 15:36     ` Tom Tromey
2008-04-10 15:39       ` Pedro Alves
2008-04-17  2:58         ` Tom Tromey
2008-04-10 15:53       ` Daniel Jacobowitz
2008-04-17  2:47       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ftldhf$1v0$1@ger.gmane.org' \
    --to=ghost@cs.msu.su \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox