Daniel Jacobowitz wrote:

> On Thu, Apr 03, 2008 at 05:32:23PM +0400, Vladimir Prus wrote:
>> +   Copyright 1992, 1993, 1994, 1995, 1999, 2002, 2003, 2007, 2008
>> +   Free Software Foundation, Inc.
> 
> Just 2008.
> 
> Otherwise OK, thanks.

Unfortunately, while testing before commit I found an issue. The
watchpoint.exp test fails when running in always-inserted mode. I'm
not sure why I did not see that failure before, but at least I've
fixed it.

The problem was that when watchpoint is disabled, we failed to remove
the watchpoint from the target. We had the same bug for regular breakpoints,
but since for regular breakpoints we still do remove-insert dance when
stepping over breakpoints, the issue does not manifest.

I attach the revised patch, together with the delta relative to the
previous one. This has no regressions, neither in always-inserted nor
default mode. OK?

- Volodya