From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gabriel Dos Reis <gdr@codesourcery.com>
To: Jim Blandy <jimb@zwingli.cygnus.com>
Cc: gcc-patches@gcc.gnu.org, Daniel Berlin <dberlin@cygnus.com>, Michael Elizabeth Chastain <chastain@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Extend demangler to recognize destructors/constructors
Date: Thu, 15 Mar 2001 01:15:00 -0000
Message-id: <fld7bj8kbk.fsf@sel.cmla.ens-cachan.fr>
References: <200103150901.EAA25623@zwingli.cygnus.com>
X-SW-Source: 2001-03/msg00219.html

Stylistic notes.

Jim Blandy <jimb@zwingli.cygnus.com> writes:

[...]

| + 
| +   /* Set to non-zero iff this name is a constructor.  The actual value
| +      is '1', '2', or '3', indicating a complete object, base object,
| +      or complete object allocating constructor.  */
| +   int is_constructor;
| + 
| +   /* Set to non-zero iff this name is a destructor.  The actual value
| +      is '0', '1', or '2', indicating a deleting, complete object, or
| +      base object destructor.  */
| +   int is_destructor;

May I suggest use of enums to make it much more readable?  I realize
that makes  

       dm->is_destructor = peek_char (dm);

less straigthforward but will make use of

     int
     is_gnu_v3_mangled_constructor (const char *name)

and 
     int
     is_gnu_v3_mangled_destructor (const char *name)

self explanatory.


-- Gaby
CodeSourcery, LLC                       http://www.codesourcery.com