From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20357 invoked by alias); 28 Nov 2007 16:23:39 -0000 Received: (qmail 20348 invoked by uid 22791); 28 Nov 2007 16:23:38 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Nov 2007 16:23:28 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IxPfH-0000ZC-GN for gdb-patches@sources.redhat.com; Wed, 28 Nov 2007 16:22:01 +0000 Received: from 77.246.241.246 ([77.246.241.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Nov 2007 16:21:31 +0000 Received: from ghost by 77.246.241.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Nov 2007 16:21:31 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [RFA] Don't reset watchpoint block on solib load. Date: Wed, 28 Nov 2007 16:23:00 -0000 Message-ID: References: <200711202013.47537.vladimir@codesourcery.com> <200711281858.51145.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00523.txt.bz2 Vladimir Prus wrote: > I attach the revised patch with that extra if, does it look OK? In fact, you might want to hold off reviewing this patch until: 1. I post revised patch to make watchpoints use multiple locations, which will also introduce a single function to update watchpoint that will be used in breakpoint_re_set_one. 2. I figure out why current unmodified GDB does not actually handle watchpoints on variables in shared libraries that get loaded, and segfaults. - Volodya