From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12497 invoked by alias); 8 Nov 2007 18:36:09 -0000 Received: (qmail 12484 invoked by uid 22791); 8 Nov 2007 18:36:09 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Nov 2007 18:36:01 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IqCDs-0000m7-MW for gdb-patches@sources.redhat.com; Thu, 08 Nov 2007 18:35:54 +0000 Received: from 77.246.241.246 ([77.246.241.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 08 Nov 2007 18:35:24 +0000 Received: from ghost by 77.246.241.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 08 Nov 2007 18:35:24 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: Cleanup pending breakpoints floatsam Date: Thu, 08 Nov 2007 18:36:00 -0000 Message-ID: References: <200711081155.47340.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit User-Agent: KNode/0.10.4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00175.txt.bz2 Jim Blandy wrote: >>> (This patch was mechanical and touched a number of functions, so I can >>> understand why you'd rather put off writing the ChangeLog entry for >>> it. But in general, a patch should be posted with a ChangeLog entry: >>> it helps reviewers understand the patch, and of course the entry is >>> subject to review itself.) >> >> It's this a bit too pedantic, for this case? This is as mechanical patch >> as it can get, so ChangeLog won't have much value in understanding the >> patch. > > What I meant was, in this case it's not a problem, for just the reason > you say. But in general, patches should include ChangeLog entries > when posted for review. Surprisingly, should you get to my second patch for today, you'll see a changelog entry there :-) - Volodya