From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 2FA393858D35 for ; Wed, 10 Jun 2020 12:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2FA393858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BEAA6AA7C; Wed, 10 Jun 2020 12:49:56 +0000 (UTC) Subject: Re: [PATCH][gdb/symtab] Handle .gdb_index in ada language mode From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200513094147.GA20499@delia> <87tv0b64yd.fsf@tromey.com> <89719b8a-9252-7af5-3ad8-1bcd1ebbc80c@suse.de> <87zh9z1zkr.fsf@tromey.com> <2795c8df-ab53-463a-5b2a-d3acf3f2ce31@suse.de> Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Wed, 10 Jun 2020 14:49:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <2795c8df-ab53-463a-5b2a-d3acf3f2ce31@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 12:49:55 -0000 On 02-06-2020 12:47, Tom de Vries wrote: > On 22-05-2020 22:31, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> Using this patch, I managed to get it working. >> >> Wow, cool. >> >> Tom> The patch does the following: >> Tom> - enable ada .gdb_index by removing the ada check in write_psymbols >> Tom> - copy some ada-specific code from debug_names::insert to >> Tom> write_psymbols >> Tom> - disable a workaround for gold/15646 in dw2_expand_marked_cus >> >> Tom> As for the disabled workaround, I ran into trouble in >> Tom> gdb.ada/access_tagged_param.exp, where setting a breakpoint on foo failed. >> >> Tom> The index shows that there are two entries for foo, one variable, one >> Tom> function: >> Tom> ... >> Tom> [3733] foo: >> Tom> 3 [global, variable] >> Tom> 5 [global, function] >> Tom> ... >> Tom> The workaround skips the function, so disabling the workaround allows >> Tom> the test to pass (my guess atm is that the workaround is not precise >> Tom> enough). >> >> Looking at the gold bug, I suspect what's needed is to rule out >> duplicates that have the same kind. >> > > The workaround has been limited: > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f030440daa989ae3dadc1fa4342cfa16d690db3c > . > >> I tend to think you should push your previous patch, and maybe we can >> revisit this stuff later. >> >> Tom> + std::string decoded = ada_decode (name); >> Tom> + if (decoded[0] == '<') >> Tom> + name = (char *) strndup (decoded.c_str () + 1, decoded.length () - 2); >> Tom> + else >> Tom> + name = strdup (ada_encode (decoded.c_str ())); >> Tom> + } >> >> This leaks the string. > > Fixed in a new version of the patch, submitted as part of patch series: > - "[PATCH, 1/2][gdb/symtab] Fix name lookup in dw2_map_matching_symbols" > https://sourceware.org/pipermail/gdb-patches/2020-June/169213.html > - "[PATCH][gdb/symtab] Enable ada .gdb_index" > https://sourceware.org/pipermail/gdb-patches/2020-June/169214.html > > [ Note the missing ", 2/2" in subject of second patch. ] I've committed these two patches. Thanks, - Tom