From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cceFM9ExWmDsQgAAWB0awg (envelope-from ) for ; Tue, 23 Mar 2021 14:22:09 -0400 Received: by simark.ca (Postfix, from userid 112) id C61571EF78; Tue, 23 Mar 2021 14:22:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 24D1F1E939 for ; Tue, 23 Mar 2021 14:22:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C1E63858002; Tue, 23 Mar 2021 18:22:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C1E63858002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616523728; bh=zvjRBGAblrT5SgJZXoqPxAwA1AJUygx6AvibOJRepfw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QYrevz1djqCw+im+3u9gHLTL4uaBfpFMAjqPp/z8/LS4cQQGjs2DNqhYzXM+MsOdi uUH1Hnb6U9qehG+roHSqROXOqj0oXrPc4u1IJSRL7pZgFBMNIXFepheGShqtBb9gLl DMyH3JNZ0yCkaQZrcAqbHEMYfCPNAQtY2j3UGnbU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 47FA73858002 for ; Tue, 23 Mar 2021 18:22:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47FA73858002 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12NILw3h028955 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 14:22:02 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12NILw3h028955 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0879B1E939; Tue, 23 Mar 2021 14:21:58 -0400 (EDT) Subject: Re: [PATCH] gdb: make gdbpy_parse_command_name return a unique_xmalloc_ptr To: Andreas Schwab , Simon Marchi via Gdb-patches References: <20210323175546.3836508-1-simon.marchi@polymtl.ca> <87v99hn3qt.fsf@igel.home> <7b88c9bd-f959-d4a7-4b29-91b46a9f05d8@polymtl.ca> Message-ID: Date: Tue, 23 Mar 2021 14:21:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <7b88c9bd-f959-d4a7-4b29-91b46a9f05d8@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Mar 2021 18:21:58 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-23 2:11 p.m., Simon Marchi via Gdb-patches wrote: > On 2021-03-23 2:07 p.m., Andreas Schwab wrote:> On Mär 23 2021, Simon Marchi via Gdb-patches wrote: >> >>> @@ -545,14 +540,19 @@ cmdpy_init (PyObject *self, PyObject *args, PyObject *kw) >>> /* If we have our own "invoke" method, then allow unknown >>> sub-commands. */ >>> allow_unknown = PyObject_HasAttr (self, invoke_cst); >>> - cmd = add_prefix_cmd (cmd_name, (enum command_class) cmdtype, >>> + cmd = add_prefix_cmd (cmd_name.get (), >>> + (enum command_class) cmdtype, >>> NULL, docstring, &obj->sub_list, >>> pfx_name, allow_unknown, cmd_list); >>> } >>> else >>> - cmd = add_cmd (cmd_name, (enum command_class) cmdtype, >>> + cmd = add_cmd (cmd_name.get (), (enum command_class) cmdtype, >>> docstring, cmd_list); >>> >>> + /* The above doesn't copy nor take ownership of the name... so we just >>> + leak it. */ >> >> s/leak/release/? > > I really wanted to say "leak", as we release it without an owner and > accept it will never be freed. Sometimes we release in order to > transfer ownership to the callee (who hasn't been updated to use unique > pointers yet), but that's not the case here. I think the comment would > be clear with either word. Ah, I think I'm mistaken, the Python code uses: cmd->name_allocated = 1; Which means the cmd_list_element would free the name if it ever gets deleted. I'll change the comment to: /* If successful, the above takes ownership of the name, since we set name_allocated, so release it. */ cmd_name.release (); However, name_allocated isn't set in py-param.c, I guess it should... Simon