From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113584 invoked by alias); 30 Nov 2016 12:10:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113494 invoked by uid 89); 30 Nov 2016 12:10:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=til, Hx-languages-length:1342 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 12:10:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92697C04B30E; Wed, 30 Nov 2016 12:10:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUCAk9U031644; Wed, 30 Nov 2016 07:10:46 -0500 Subject: Re: [PATCH 18/22] ui_out_table: Replace boolean flag with enum To: Simon Marchi References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-18-simon.marchi@polymtl.ca> <60a2d96b57c23614647389c4b54af2fa@polymtl.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 30 Nov 2016 12:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <60a2d96b57c23614647389c4b54af2fa@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00977.txt.bz2 On 11/26/2016 04:47 PM, Simon Marchi wrote: > On 2016-11-24 13:42, Pedro Alves wrote: >> On 11/24/2016 03:27 PM, Simon Marchi wrote: >>> This patch is just a little cleanup, it replaces the body_flag field of >>> ui_out_table with an enum. It expresses more explicitly the >>> intent of the field (check that state == TABLE_STATE_HEADERS conveys >>> more what we want to do than checking for !body_flag). >> >> Yay for avoiding the boolean trap. >> >> >>> @@ -271,7 +279,7 @@ ui_out_table_begin (struct ui_out *uiout, int >>> nbrofcols, >>> previous table_end.")); >>> >>> uiout->table.flag = 1; >>> - uiout->table.body_flag = 0; >>> + uiout->table.state = ui_out_table_state::TABLE_STATE_HEADERS; >> >> Nit: This one stood out, as none of the other places fully qualify >> the enum. >> >> You could also consider moving the enum to within >> the table class, and/and use "enum class" to shorten the >> names, if you want to scope it. > > TIL about "enum class". > > In patch "Class-ify ui_out_table", I move it to the ui_out_table class. > If that's ok with you, I'll look into making use of enum class in that > patch. Ack, I'll go look at it. > I'll remove the "ui_out_table_state::" in this instance for > consistency. Thanks. This patch LGTM with that. -- Pedro Alves