From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yQ1DI5Mu6mmz1zYAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 10:37:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776955027; bh=D5QxfB1uA/f72JpsRRZenWOWJjS83p8167CxnygiSlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WQPtAoT+cnkrSoKpddw9KxLJO7UhT45o9MPBjUHTtDXFPwVvwowRr+cwyq4cAMvyc fttjafcZADSF8q2EyuB1HCjevLFCxrBJZXk60zEvhJgiq2ltbNHPcQ/oDTlbrEzUUl 9Q8m9QB9zgDe8AjHxE3Za3wNiD86YcG7aF/e28Wk= Received: by simark.ca (Postfix, from userid 112) id 8B88D1E067; Thu, 23 Apr 2026 10:37:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=NWeVM8ig; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 759161E067 for ; Thu, 23 Apr 2026 10:37:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 099A04B8896B for ; Thu, 23 Apr 2026 14:37:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 099A04B8896B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=NWeVM8ig Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 568C34B88954 for ; Thu, 23 Apr 2026 14:36:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 568C34B88954 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 568C34B88954 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776954990; cv=none; b=lcb8nOyKVjiEEKax8wsHx1e132hLMr/FQgmeZLY4JVvRvEv2hoIeSEBNtldTHyhKMDWtCZm7s1mFTZa+0LFMzx2Q5IsRz/f4CVOapTevqtggFf3vF0CFc1IjePVkhfDxKYYjOyEtWxcAw84uI1aov09PsWGN3CORjAbEZPbRtSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776954990; c=relaxed/simple; bh=D5QxfB1uA/f72JpsRRZenWOWJjS83p8167CxnygiSlM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FDGOHXX6ilxjgJEq+syqt22c3aGAaiOS1yKeRKS3MQ1cyakx9ZWdF2NKUK4i1Lbkzjy1o9U0icURHtF8907rTiJgt+EmwXB4uHjJtpaG/gpMw7LHw/5Pgzm9V0m+5h1hjOD/hnKUb9781jixdNsvSnMJefREu8zfwZTuvhnpklc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 568C34B88954 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776954988; bh=D5QxfB1uA/f72JpsRRZenWOWJjS83p8167CxnygiSlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NWeVM8igubx7cB7HEoxflL6+0WvsigqKv6gH6GfXsoPxNQrRSbMT6JK6bMUendofH Daq9yDCk8N769Drdn22xQSVFKexJUaBwt997CAENpxZf43+EInmAbE4SCIzQZPFpwc iCo5rxBPIUaDEo+wUTsdMQ/WNjLBlGIeEtqV2cTQ= Received: by simark.ca (Postfix) id B5CC81E067; Thu, 23 Apr 2026 10:36:27 -0400 (EDT) Message-ID: Date: Thu, 23 Apr 2026 10:36:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb.dwarf2: Fix fission-dw-form-strx.exp workflow To: Bratislav Filipovic Cc: gdb-patches@sourceware.org References: <20260423103929.3137187-1-bfilipov@amd.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260423103929.3137187-1-bfilipov@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/23/26 6:37 AM, Bratislav Filipovic wrote: > The test was using gdb_compile_shlib to create the .dwo file, which > runs the linker. This is incorrect for DWARF fission - .dwo files > should be created by objcopy extraction, not linking. > > Per commit 6a29913eeb9, "it was a bad idea to generate a .dwo file > using the linker, since the idea behind .dwo files is that they do > not need to be linked." > > GCC's assembler doesn't set the SHF_EXCLUDE flag on .debug_*.dwo > sections, so the linker preserves them in the output. Clang's > assembler sets SHF_EXCLUDE, causing the linker to exclude these > sections. Both approaches are valid, but only the GCC approach > happens to work with this test's incorrect use of the linker. > > Rewrite the test to use build_executable_and_dwo_files with the > split-dwo option, matching all other fission-*.exp tests. This uses > objcopy to properly extract .dwo sections without involving the > linker. > > Changes: > - Use build_executable_and_dwo_files instead of gdb_compile_shlib > - Generate both skeleton and DWO CUs in single Dwarf::assemble block > - Add debug_str_offsets section for DW_FORM_strx support > - Add is_remote host check (required for objcopy-based workflow) > - Fix DW_AT_dwo_name to match generated filename > > Tested: GCC 13.3.0, Clang-23 (passes) Thanks, that LGTM. Approved-By: Simon Marchi Just a nit: when sending a version 2 of a patch or patch series, pass `-v2` to git-send-email to make it add "v2" in the subject prefix. However, it seems that you used --in-reply-to to keep the new patch in the same thread as the original on, that is very nice and thoughtful, thank you. Simon