From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DLTMLflpDmYO9SIAWB0awg (envelope-from ) for ; Thu, 04 Apr 2024 04:51:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=kAzDp2O4; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=kAzDp2O4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A16A31E0C0; Thu, 4 Apr 2024 04:51:05 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6990C1E08C for ; Thu, 4 Apr 2024 04:51:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C0B54385840C for ; Thu, 4 Apr 2024 08:51:02 +0000 (GMT) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2050.outbound.protection.outlook.com [40.107.7.50]) by sourceware.org (Postfix) with ESMTPS id 192403858D34 for ; Thu, 4 Apr 2024 08:50:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 192403858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 192403858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.50 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712220641; cv=pass; b=CuWYkrAglgRmx+4wx+QW+TbcXBOf3SgB75pOw6T096jPbFsNYWLe35qaBncsuw6NFudbBxHuHmIdw5SVpdqx5f/ED8sND7nD3XOE0DuaViI8PRXyb/PBLLEJBBJj5/1X2bWcv70g8XpWyco8wi+Dt9mkDzPYIeFcp0UvL25nzdU= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712220641; c=relaxed/simple; bh=ijJ2uvwxMQWw0k2Lis63f7WjD+2N3oTtKvgD5AJv3bo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=G2iF8qNkgeRnIlG4eshbiiAZwQcJ1Pm30XsChzESwqrpZL4t2tpj420iaBt85nid8qnBrnnPNK8dKJDznJ4HRJoTRd4WYRApuYIo3m+uNSnexEqPrju4Q6X2IJAkOFCvILSAhxQ5KOm2I7NNZ5bP3RXQWcsXw7RwvUTvN28lbTo= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=daK1sTBtFp1CM9708SjAJoL80yJadJ+mxff5WWwW+cgq68uPCQxnbZLIQpflVe3VMJjTMkFRSDRDHinb0Va0Q3ZzZAsPEWy4frIKJUY1WoeyBdFs3WiV3aOUWmNJPv1zzWOqhnA4E4bbqOHVg6Y8y+f+mA0mAk5N8JanFiTkfhA1zZS7Mvoke7weJdUVUnTwzr+Z8qPBkU1cSo+NVf8Mvn95zCJj/by/Nrh7JtJI0ZkQGE0u4nLybQ4uiDN4Ew4mXkSB0tf/sQmXcNwncr6N6YWWVSUr2M4JmD6Dvc6w6Nv7eHsbZqy8iABPvXaSDehSABxt5p7XTgdL9sulKAXymg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N6CaoUtOOWxkYPPbZiCCiqAj1UL60s6SPRzvSgxMwqw=; b=Dlm3b/7ltvrUsFIpfoGJYug7YVvI8k063/tmCAZNkseRvEVt4pBDLHar2tesbIPxdQ7YYDZgtPqUdaJBL5s1AhZevCR60mHz8OvTGGnUVEau4G6rvhwdy5Nv3ds3I0bNyRulElNt7pRGG61ULeviksh8FlQ2TNK7mliM2djV5Po6iuwtUrvvFsFFMISaxgTzYkK0Pj2oZYuSpkBqJ1nIe6ehWCEJMTXaxtrwx6suS8L8SEVgR73DgWET+5veyamiRuq1/ajAxPQzaEzCQLw39a4hai2m5338cugh7+Dv4CFWgweNMMPQtUD9/72n1AYG0jy50zmrWbFoBsRM/O9avA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N6CaoUtOOWxkYPPbZiCCiqAj1UL60s6SPRzvSgxMwqw=; b=kAzDp2O4UplP74F/BhfmfiHOWXtZY4Jq2ov1yE3BbCIhyEc6xWJ3KcC0JVyQ3rdiwnNtjPk6HxVBYHZTFk0cL0cMqZSfLaXuT1q4/60QXlsQgPpvG6mDTlUFernwt33tL8vmvZZ1AB+64aZQQAME/umFLX1GOgRCcZjjCvcQ3P8= Received: from AM0PR04CA0039.eurprd04.prod.outlook.com (2603:10a6:208:1::16) by PA6PR08MB10813.eurprd08.prod.outlook.com (2603:10a6:102:3d3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 08:50:34 +0000 Received: from AM4PEPF00025F97.EURPRD83.prod.outlook.com (2603:10a6:208:1:cafe::e5) by AM0PR04CA0039.outlook.office365.com (2603:10a6:208:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Thu, 4 Apr 2024 08:50:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00025F97.mail.protection.outlook.com (10.167.16.6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.0 via Frontend Transport; Thu, 4 Apr 2024 08:50:34 +0000 Received: ("Tessian outbound dc0a9029eb2c:v300"); Thu, 04 Apr 2024 08:50:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: abc5de8e997892e9 X-CR-MTA-TID: 64aa7808 Received: from a9df7a14ff0a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 62731B6E-FE23-471D-9C72-DC884574D5AB.1; Thu, 04 Apr 2024 08:50:27 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a9df7a14ff0a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Apr 2024 08:50:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L+SsMeF3YlXuFyDHp1rmnnhdaHU/apzQninjXf1HifH8q0ZSuRV1XFdioKt5YnFs2zqnU4cetgnvJowrrnbmn6IdLXf6AfmD2V4f5IHUXFeqWH+JhRJHEr40cmd9m82ek26epPCKlUoGneWFT8rDOvPYSa9yqzjBv5e7bf528hAksQwLnq6MfyBmG6//cCRi2e7rsuluKe9m/J52hStFFHemvDv4uCLBz/pBRqQtvd4JLgnNnsJ+Cxjniq8o4jAhUluy4APweAfeGwKdAnZB7/4VksfpzhRhxy0JZXN+XUCd4h/04TqOUIP1m9dkGgrMXf2KBNa4HX+LJdvLR9/KkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N6CaoUtOOWxkYPPbZiCCiqAj1UL60s6SPRzvSgxMwqw=; b=EW4psQun9v7/NkePm9BSP5qvT7H0SysR39hWhVmzboMMfdD9qKNEQdt69ICMCscsoc1yoSoFVWcJHVlQGC76O3R+DBdC+jcDhF33rOuqWC209owwF514eSz+N5UdELBV8Gh1eS9q18pfe2eNfTxjCOSeNQWj6lQev/cFsZ+iqAUwxkFP/xE4R3V0GXbkePtHBxFg6NFrHAS2X8/ZgyMtqhCJLyFUGJlSQuggNSoHVmt3lY6P8bJ3WCIK41DaDQOvBNqH+ABWBFsMRMpTCqDlwA9XIQAT0g7mobu4UvNuobV6NJFj3LqbPQpXGMoWCBGHOWFQR1Jp15kchDPCXt9Q6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N6CaoUtOOWxkYPPbZiCCiqAj1UL60s6SPRzvSgxMwqw=; b=kAzDp2O4UplP74F/BhfmfiHOWXtZY4Jq2ov1yE3BbCIhyEc6xWJ3KcC0JVyQ3rdiwnNtjPk6HxVBYHZTFk0cL0cMqZSfLaXuT1q4/60QXlsQgPpvG6mDTlUFernwt33tL8vmvZZ1AB+64aZQQAME/umFLX1GOgRCcZjjCvcQ3P8= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB3PR08MB8820.eurprd08.prod.outlook.com (2603:10a6:10:438::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 08:50:24 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 08:50:24 +0000 Message-ID: Date: Thu, 4 Apr 2024 09:50:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb: Make tagged pointer support configurable. Content-Language: en-US To: "Schimpe, Christina" , "gdb-patches@sourceware.org" References: <20240327074739.2969623-1-christina.schimpe@intel.com> <20240327074739.2969623-2-christina.schimpe@intel.com> <8e7bbf75-4914-42a3-a97c-a28beca5378e@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0298.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::22) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB3PR08MB8820:EE_|AM4PEPF00025F97:EE_|PA6PR08MB10813:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z1dSwpn1yT2mvaoDeJUCSLVBofoeKY+uoQX5Oic5fh6BLfigOWcXaiK5EqnzNuZo0R2VNWG3eC8IUKmaFSDW5h2CGR7RP7dXsVxw2xbrYA7m0JDrVvatlBGSPF8R0EJRnKJqakphfI6m91hi3yu8OHTfo6kCRhDmRC5bK6eYy4xJcqmuzEJVeY70NeiwJotap4k2QLJoh7CNewpZxzBbQ4DPDy48OLwG/nmYkTWltP7t2c5NQML2sr8y/Vf1bDIScUpRDeK14peeIFEnSRfcZAo77E7P7dmVYj/TnuEr2v9Mg+X1B+3H9KsR49FX/IpbfTNUfYGr/Lo2IGtIsQw58DLeU2rB5/jpB1zDpHx6q4cDfQTZKUnUHmRkiKHBYntQfz4SaUnWO0093aY4E0qmsFwCnsVObZAcboiRubsQdT+J8AdlQi5qg1kjeRvVWq2nVctiBpC+S3Zj7vkuTK1MhxZ5VwqxRR7qNQMHF+6C0rAy6k+XxhFBIPKqivHpqcnvGrnxYnkkN/u61QVqxIwS6diV2Kjgf7nJ999GhOa8ePofrFYXV8z/3eUdmjaRLiy+XcE1E0b6jY+MYITPuKw/dhmtiRZy75hgsT48mVaMmNE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8820 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F97.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c54801c4-f477-4f8e-a4c5-08dc54844a82 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TOWWU4zR0SkY6P6Y9CmzixJjEotfH4sdHXOAXufTYHIg7Nu+ftP+4aX06P7JqTI7tyAa/lSG7d3EDU5YGMzy1ez5XkVUIfGLpZwHo9BqqJyh7C07Agl60mCSdoQstJchLb7Y8NG3fOvELqXT1fotFtA9Gbwo9v0ZG+GERNOaWEgZcfdUnQSSZNCOwFWBep+jidEhd2jam72aT9NkQ9KzIrH4xDBkZB7UGiEYonZlEA9F5ZwyVZQ/kQ4TQDIpFya7QRK81rI8q6ZNw6AUDPXxh1ERp6/svE+oY4vs6ggyk7UFGGmyw7gBgnBsYEmc1dv/Fbi17AA4QqMT63qxyYyLP2yTjAicQj4nR7zVlLWeynInW/3yn1BCkqPs2Z9sKB5yUAtXohXASLfYkTQNGoMqru+5HX0NdhdtU3PhHVD4EdAJZwpp3/BfxvLB+2+g0OaS/mfa5NX617oo33iRJAI8mvtbG35XHgZNk+lKb++pb6OMuRiY1cnibXRWO0PoBTexI16saoNyir/zXj2e6gRkMeQ7svLheTaLVXurlVMUO+ZXELnpFfdTZyp7nN15UdGY3aEZqTs62ImyIK1qHzRCk82UfcR8zgPh198mjJy6EjzLS3WM/GSBzByGGQhpzEi8UqAFvlr2rjxKWmOfMAUJDd3/cH/aq5g/4g2JbWPxEm7BSc4An2JTn2Xowj02Nq+Hs9zr535GtW8Y7BC2dFzHHQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 08:50:34.1791 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c54801c4-f477-4f8e-a4c5-08dc54844a82 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F97.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10813 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 4/4/24 09:18, Schimpe, Christina wrote: > Hi Luis, > > Thanks a lot for your feedback! > >> Thanks for the series. More of a general question, we're splitting the more >> general handling of bit removal from addresses into 3 different categories in >> gdb. Isn't gdbserver also affected by this change? At least for aarch64 we have >> non-address-bits removal. > > Hm, so far I don't see an issue with gdbserver. > IIUC, the aarch64 non-address-bits removal with gdbserver is due to the exception > "for signals raised in response to watchpoint debug exceptions" described in commit > "Fix TBI handling for watchpoints". Is there anything else that I might have missed? > For amd64 we don't have this exception. > Ah, indeed. You're right. >> Do we need to do anything in gdbserver so it can properly handle removal of >> non-address-bits on its own, without the help of gdb? >> >> Also, another more general comment is related to the naming of the hooks. I >> suppose it is down to personal preference, but spelling out the entire word is >> likely to make the meaning of a function/hook clearer. For instance: >> >> gdbarch_remove_non_address_bits -> >> gdbarch_remove_non_addr_bits_memory >> >> Maybe we should... >> >> gdbarch_remove_non_address_bits -> >> gdbarch_remove_non_address_bits_memory >> >> The same applies to the other hooks and function names. >> >> wpt -> watchpoint >> >> or >> >> wpt -> hw_watchpoint >> >> bpt -> breakpoint >> >> or >> >> bpt -> hw_breakpoint >> > > I thought that "addr", "bpt" and "wpt" are well known abbreviations in GDB and > preferred to have shorter function names in that case. > But I am fine with adapting the function names, too. It is (and used to be). Nowadays there seems to be a slight preference for being a bit more verbose and clear. > > Christina > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928