From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85430 invoked by alias); 17 Nov 2016 16:52:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85420 invoked by uid 89); 17 Nov 2016 16:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 16:52:04 +0000 Received: by simark.ca (Postfix, from userid 33) id 1D66E1E81B; Thu, 17 Nov 2016 11:52:03 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 17 Nov 2016 16:52:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <773f613d-7157-258e-bb1c-daf86a7ec0d3@redhat.com> References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-4-simon.marchi@ericsson.com> <773f613d-7157-258e-bb1c-daf86a7ec0d3@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00485.txt.bz2 On 2016-11-16 14:10, Pedro Alves wrote: > IMO, whether to explicitly remove default suffixes from the > the implicit rule suffixes list for efficiency is a separate > subject, since we're not currently doing it either. > > Just to be sure none of the default suffix rules is necessary, > can you confirm: > > 1. that "make -r" (from scratch) still works. "make -r" from scratch from the top-level fails in the readline directory: ar: readline.o: No such file or directory It seems like readline relies on implicit rules. It shouldn't be affected by gdb disabling them though. I did a "make" in the readline directory to make it build, then resume the top-level build with "make -r", and it finished cleanly. > 2. that "make -r diststuff" in the gdb build dir still works. The commands completes successfully, so it looks good. Still, perhaps Joel should be a little bit more careful when doing the next release to make sure nothing it missing. > If the above work, then this is OK with me to push in. Just to be clear, this patchset does not disable the default suffix rules, so I don't think it was really necessary to check that for this patch. But at least we know it's safe for when we'll want to disable them. Thanks, Simon