Re: [PATCH 1/2] Bump to autoconf 2.69 and automake 1.15.1

Alan Modra
2018-06-18T02:46:41Z

On Fri, Jun 15, 2018 at 11:55:40PM -0400, Simon Marchi wrote:
> On 2018-06-15 09:39 PM, Alan Modra wrote:
> > On Fri, Jun 15, 2018 at 03:22:10PM +0100, Nick Clifton wrote:
> >> Otherwise so far, my testing has been showing no signs of any real problems.
> >
> > The patch looks good to me too. I did see some generated file
> > differences, most of which disappeared when I compiled my own
> > autoconf-2.69 rather than using the Ubuntu 18.04 version (which
> > apparently has some patches from autoconf-2.70 applied).
> >
> > I applied both of your posted patches, ran autoconf in zlib since
> > you'd said the posted patch was broken, touched all the files in the
> > first patch, then built binutils-gdb with --enable-maintainer-mode.
> > Apart from .pot files, these were the files that differed:
> >
> > bfd/doc/Makefile.in
> > binutils/doc/Makefile.in
> > gas/doc/Makefile.in
> > gdb/aclocal.m4
> > gdb/config.in
> > gdb/configure
> > gdb/gnulib/aclocal.m4
> > gdb/gnulib/configure
> > libdecnumber/aclocal.m4
> > zlib/configure
>
>
> 1. About aclocal.m4's, there are a bunch more generated from other versions of
> automake than 1.15.1:
[snip]

> Should I make sure to re-generate all of them?

Yes, I think that should be done whenever updating the version of
autotools.

I also just noticed these 1.11 version specifiers that probably should
be updated to 1.15:
./bfd/Makefile.am:AUTOMAKE_OPTIONS = 1.11 no-dist foreign
./gas/Makefile.am:AUTOMAKE_OPTIONS = 1.11 dejagnu foreign no-dist subdir-objects
./gprof/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist no-texinfo.tex info-in-builddir
./opcodes/Makefile.am:AUTOMAKE_OPTIONS = 1.11 foreign no-dist

> 2. How do I update those */doc/Makefile.in?

Andreas has already given the canonical answer, but something like the
following should work too.

cd ~/src/binutils-gdb/bfd && automake-1.15 --foreign doc/Makefile
cd ~/src/binutils-gdb/binutils && automake-1.15 --foreign doc/Makefile
cd ~/src/binutils-gdb/gas && automake-1.15 --foreign doc/Makefile

--
Alan Modra
Australia Development Lab, IBM