From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9E3FA386186A for ; Mon, 7 Sep 2020 19:24:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E3FA386186A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 475FE1E554; Mon, 7 Sep 2020 15:24:38 -0400 (EDT) Subject: Re: [PATCH v2 09/10] Switch local native code to gdb/nat shared functions To: Kamil Rytarowski , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-10-n54@gmx.com> From: Simon Marchi Message-ID: Date: Mon, 7 Sep 2020 15:24:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200904002905.13616-10-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 19:24:39 -0000 On 2020-09-03 8:29 p.m., Kamil Rytarowski wrote: > No functional change as the same functionality inlined in nbsd-nat.c > is offered in gdb/nat/netbsd-nat.c. > > gdb/ChangeLog: > > * nbsd-nat.c: Include "nat/netbsd-nat.h". > * (nbsd_nat_target::pid_to_exec_file) > (nbsd_nat_target::thread_alive, nbsd_nat_target::thread_name) > (nbsd_nat_target::post_startup_inferior) > (nbsd_nat_target::post_attach, nbsd_nat_target::xfer_partial) > (nbsd_add_threads): Switch local code to common gdb/nat functions. > * (nbsd_pid_to_cmdline): Call sysctl from the global namespace. > * (nbsd_thread_lister): Remove. Just a though for next time: I think you could have done the changes here progressively. For example, move netbsd_thread_lister to nat, adjust the code here at the same time. Move the thread_alive function, adjust the code here, etc. It would have been easier to see that it was mostly just functionality moved from one place to the other, up to this patch I thought it was all new code. Simon