From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xminEC59ump7EhIAWB0awg (envelope-from ) for ; Mon, 28 Sep 2026 10:43:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2L2Friab; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=53YqfRFb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sSrz4wYK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zIHs0TR2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3305A1E01F; Mon, 28 Sep 2026 10:43:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7F9B21E01F for ; Mon, 28 Sep 2026 10:43:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 19C014BAE7EB for ; Mon, 28 Sep 2026 14:43:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19C014BAE7EB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2L2Friab; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=53YqfRFb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sSrz4wYK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zIHs0TR2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id BFADF4B9DB51 for ; Mon, 28 Sep 2026 14:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFADF4B9DB51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFADF4B9DB51 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790606608; cv=none; b=Z9j8JtAw/kjQ5mrljcPtl80BWBF0MNBfbXvx29Z2Uv8Le1uqAqHRMuxaZPVq7M7/+jLr4qowaWUR1QnGT9/7yjeCGvRA0Dp7HamOpL62nzw0RGyo63D0QbH/CDhhoV8zjVTT9vI4P+UXWjWuJBdzVwROXhM5pvLOuyhy7qQ+/XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790606608; c=relaxed/simple; bh=3PIi2fSdGdMiE89Vd/MW67wMk8ZaZ6WaD5uWloy3Zsg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=gl7jWWHogleX7Zp1QuSxy61DIhD86YSQzZqe15Lhuxi9pqlTkh9FpzkNalVRxOihik9bGDpB9K9GCK63qbH35Dx/80wLXRpBUeDV9ZFIfLwCwWO+RkFHpaoFFVOEnkphdHnEnQRp7pVeCA6VcgW2IXikDCr2wR7fpc5zr3bqiOg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=2L2Friab; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=53YqfRFb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sSrz4wYK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zIHs0TR2 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFADF4B9DB51 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90B4C1FB20; Mon, 28 Sep 2026 14:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790606603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hY8ThHTn6nFKOKsNTZeI/sI2TBlEyrZkE5iNH4yxBvw=; b=2L2FriabJknrNTjvpMmGVLwv/jCtbfrdEgHc2o81RM1hyZ7kRzksyTzG1j7irYhvoSYh3x tb6d2qqu50zci5segDyEAypBxc0ry+18n+++ZBsnyOpy4ZS2gTq6g2hUiEn0fuoAWIBr9d uBPuwhOiXsuXrYUXe1Hw3devy51MZ4E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790606603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hY8ThHTn6nFKOKsNTZeI/sI2TBlEyrZkE5iNH4yxBvw=; b=53YqfRFb8GypoUOnRh/7VjxfY/sMNPaLX+yVoo1A+lMLQ1Qw9D1iEnvT3hrhwgHW8Dtw3C ri3fhBVczZ3AzrDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790606599; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hY8ThHTn6nFKOKsNTZeI/sI2TBlEyrZkE5iNH4yxBvw=; b=sSrz4wYKdaThLqzuIM1OURMgkY+BZ/+Ey95dcSTkdyk4at1jqkGpvxkefoj6G2n282p67B 5mrCqvFpTAKB1fSDnCUNFOSDOOBs8aaR0r1W77Ic+DGdTvYWbfrWAKIXDgfXTaxDPLDQ1u ykMWSliX+EzSjVPqxyK5WLTdN/fwmZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790606599; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hY8ThHTn6nFKOKsNTZeI/sI2TBlEyrZkE5iNH4yxBvw=; b=zIHs0TR22W2fpjNzYhDFA7xZIOdQroce4MAljNG4IpLRxPqhfVlaDBHkbmGc0C0VgRhSWp cVPXfUEjbBQQ58BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 59FF5133F1; Mon, 28 Sep 2026 14:43:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id owQyCAd9umopDQAAD6G6ig (envelope-from ); Mon, 28 Sep 2026 14:43:19 +0000 Message-ID: Date: Mon, 28 Sep 2026 16:43:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Refactor svr4_solib_ops::lm_addr_check To: Guinevere Larsen , gdb-patches@sourceware.org References: <20260911191940.2892092-1-tdevries@suse.de> <334ae7d5-410d-470c-b370-2fb099bbecd8@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <334ae7d5-410d-470c-b370-2fb099bbecd8@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/28/26 4:16 PM, Guinevere Larsen wrote: > Hi Tom! > > Thanks for doing this! The final result is indeed much simpler to read, > and the refactor is quite straight-forward. > > Reviewed-By: Guinevere Larsen > > Hopefully this gets approved soon! Hi Guinevere, thanks for the review. I think for a refactoring patch your review (as well as a Claude Code one) is sufficient, so I've pushed this. Thanks, - Tom