From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id et0EKvAhC2pIlgUAWB0awg (envelope-from ) for ; Mon, 18 May 2026 10:28:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8D8391E090; Mon, 18 May 2026 10:28:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B0F21E024 for ; Mon, 18 May 2026 10:27:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A63874BB1C1F for ; Mon, 18 May 2026 14:27:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A63874BB1C1F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010018.outbound.protection.outlook.com [52.101.69.18]) by sourceware.org (Postfix) with ESMTPS id 6B8A14BAE7DA for ; Mon, 18 May 2026 14:27:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B8A14BAE7DA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B8A14BAE7DA Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.69.18 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779114452; cv=pass; b=aJKq7fWEvdTBCr3SS4alz9McOz0Bnqw2CZTQ9HdSIpCeEE2MvwrEhIW8OtdSAJTou9if4yiGecvEcgdDpnTy7Qd4mftUr1MTZBRsHChmmbGesYhADHvNSZC44ChgAau+uNxdy2rTy910JNxefXWbEHEePK2O7S7auipxVOv7hmo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779114452; c=relaxed/simple; bh=8nsOF13l1u1LM9xe+LPBIbvYm0dhHT3RJfiTmzwjq/4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=LQWeAMxPpjtVW8GeU8DD56OWwVOxWM6c5wcTF+ZVShpFp9lS56tNmgxobwmPBKNeb+sqids5eAQG3sTVRZlHPQ7IdfW8Um/NawyIeDPO6UMxsoHT9rGMyn7e1ujaotELvod3UCxPC/mjJcpqYvaZLwE9p4Odvu02/M26ninyZzk= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=hcfHMABs DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B8A14BAE7DA ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=OL3eYk9BAPL49YBsxkIBhMIpHGmtENwY5pwI4i8i6Je0HephjEf6B8FFcABcG/GDUxZ/PXeNv10UwBe9Y1DShNysifzIFRTELw/7k4cWomop+yVVYaVzweyJ92AqRJnmwXimMc0K2MWCf22Q56wzDbG7qyfDO6ym1imPpWnp53t3HJNy2bs6LKdvwDboeafiMl8e+fRto2gjcXnJgkQYzSashDQgMQ1DDQhdAi6fwh6enqHcY9CeCsnViJlJN0FcC/6dkqTZwbt13bG0qdZuSogR1EezvMeek+gXSP6csJgrkcKEKrLhJ3NOEwCu9KGSJtf6BOAlngt0Nqnm7/fNkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VWTlf1edfTyoONMkVmbcs5e9rBJEYTzQRTozlFmtDbI=; b=Rsz0cqd8HHD0JF0xBAEKMvdFpjFdjbqulutoeH62b1pl0On9Nrf2Rx/dcntiMJtW8XjQ6G+Yiz4SKDy4fXJyDhM/QOobohz9CwGIrm0dfh/7e6iZ7L3gA2meXZ4hL0pavSkvxWxjVAdD5kTgyfCCW2O9nZpPZLbiLI0txvNqrmyqNeKi22+cRTKtJciUcHCs07BdZYHhj/G3oQe4kKKEuIdltBn1lqC3jymKCt2TiKmHfwkMwZo/qUIMH/yFgs1OiCWWWzX5RpSM+zQiFo546xigSUlLhDbV1W6zlCi1B30YGNYuiv4RN/lVfnkV0Qwm02skTxSKlnyvWV3hzSUFaw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWTlf1edfTyoONMkVmbcs5e9rBJEYTzQRTozlFmtDbI=; b=hcfHMABsxusX9wyz3Ri7JOJ9QH3nxmyQc8BQD8YmgESJGYPomccCLw0vaa93TmUHLNnbQ2z6HrncgMALDBPoJDq60W198EK56PuPF66yfLOtmMKkOO6WaeCzFx/O7vFJOKAuMY8MVgFPvCuj+GjFvSeTQ5QJGh77W0eYq4jXLBA= Received: from AS9PR04CA0177.eurprd04.prod.outlook.com (2603:10a6:20b:530::10) by AMDPR08MB11673.eurprd08.prod.outlook.com (2603:10a6:20b:73c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.23; Mon, 18 May 2026 14:27:01 +0000 Received: from AMS0EPF00000194.eurprd05.prod.outlook.com (2603:10a6:20b:530:cafe::96) by AS9PR04CA0177.outlook.office365.com (2603:10a6:20b:530::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.23 via Frontend Transport; Mon, 18 May 2026 14:27:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF00000194.mail.protection.outlook.com (10.167.16.214) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.11 via Frontend Transport; Mon, 18 May 2026 14:27:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=COy0mvxMC0lyV/yzbM0QRx1zjk6eg9lcuXatOqNndaaczzQ7b1jM3S66CVYJaZDrtBD+pZNIzudK09k+/19/sgAHR8mH6KTY2eKq4s8DKTdfZKtFkRYF6QqCb2tI/iBEB4XAeN0kqpQndadByps8O8VzRW4NuuVqaFtpka15/W8hsetJPShXXmOu3lwmUreGUOS1m00iai1gUEq4yJH0IUiyCYEmIWSEqbxesFPfBICfbSrekp6tbr9jvL72n0CG65pPmIzV/ThnS4xQNGpSLbdRFYRlguR+YuO9S3aismu3TC96/mVDVn6GwZUxz0wULj0ZSJuA2Ao0J0opBZ18qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VWTlf1edfTyoONMkVmbcs5e9rBJEYTzQRTozlFmtDbI=; b=vDlOUPHZ5LYQwLea1VnkvTA3In6Lz1fImQqTr+X6bBZqE3MrWdSdPkC550hNDBj1ozPOSMeIk09pW0gUPu12o0DFtyweIEN67T3O/0Yrs6CgoVNSPP/YxtoH3qo0zFJLmo38WJabzRaYELyTzSWewBa8engi8qh+ZuHr85DMh+KxvJQaLMBaANxth89KUGDRWQ8xqIy9SW43ke6Lgk+F+VFGmpKq0TgA6kcqEtSlEbvmOfC6dIfLTFw85rUrIBG7jM9wI7j5B6o4t07G9y97Wb3GWlSvG2z8rVzzMKkDagDPDkXvZ4IowiK9OsiYdE9uFD/BLp1uJPf19brJ3zN7Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWTlf1edfTyoONMkVmbcs5e9rBJEYTzQRTozlFmtDbI=; b=hcfHMABsxusX9wyz3Ri7JOJ9QH3nxmyQc8BQD8YmgESJGYPomccCLw0vaa93TmUHLNnbQ2z6HrncgMALDBPoJDq60W198EK56PuPF66yfLOtmMKkOO6WaeCzFx/O7vFJOKAuMY8MVgFPvCuj+GjFvSeTQ5QJGh77W0eYq4jXLBA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.22; Mon, 18 May 2026 14:25:57 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%2]) with mapi id 15.20.9913.009; Mon, 18 May 2026 14:25:57 +0000 Message-ID: Date: Mon, 18 May 2026 15:25:56 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] gdb/python: add gdbpy_borrowed_ref To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-2-matthieu.longo@arm.com> <878q9kipc2.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <878q9kipc2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0114.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cd::6) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|PA4PR08MB6080:EE_|AMS0EPF00000194:EE_|AMDPR08MB11673:EE_ X-MS-Office365-Filtering-Correlation-Id: a55900b2-2033-4e81-4bbe-08deb4e9868e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|366016|11063799003|4143699003|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info-Original: OOgD0SmY0AYpgAPXjtd9GpghK+Aq1ruoitzgz8NoTMvlI7L35j82MT5WRfUG5dWK2x/fIVqHHV/8SAv3ASm6eNvWJVhW2QyIuydUXVFJy8HVWiVeanN7vk3PhzOfivW8QGhm10EBp0XHAL/X8asxPhNiTLYO72s7vHyd91zN4qIGb3JCjVMBRn8EESf9mYs0rakvyhZ7r8maoseld8gXpAsbKPuHMdB4a7A3pAs72FOEoOE8/g+6J4xYsZ4aWsEsQIKyeP4Rt67COvXuQpULlcLm1hOvQuuby1yPfGkG2tu4FpIvxo3OjAe8E6uVwoirf57yqEToqzYHLRb3yKsh8O4rZUIBwL2lxnEKgRvti2eeXRBxCSPUqShHk5Ty+3EhQroOHX6lvLOCqwnUCKfkHPRCwc1UJ6o+zUuZ5UNMqYH5l8KNb8jExTLxEzNAER3YuJZktJD4yObtngbMVpNFNjIQH3ws78lGCq45Gglz2ZFDDrsh0MADFDa+nJd8enlWFKQSINyMusedH2m5n0aF0QO4n+OTa3r38kEuR3U7X+K1SwqdZ5hX3L00DEyuhuPtF7kErNLiV5ZMeUNigguEV2wvh6oW16b70iF0M7zuoo1V0yLTlPI33tnzQTeI8mhpkrQtrYtwXOcSaytrfUiPydKdPX77usvF56OUSYdyHqmgP+hDO5+kq/G7vGxI4sZO X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(11063799003)(4143699003)(56012099003)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: WcsOdnvURWDmRvi8fpPxoHyx3lVM+X2yg1D6GGwz9/NvSRnsT6lmmr2ck+awLRPfCJook3ZwDsKYQ5XoHMiVd+Nnp/9nK92uCzFPQBF0c5H/BzBCyvSdJUHggAnTnKTXw3Zeis0AFOUdAGA3hr2tG+ZH5O7jjwguSPduSaOntiX6QwbVjVRyU0ZBETW8n/s4CQlpQPFMo6tJQtyp2n70WEeHR/oF8nq48hV7RrUUbrKipv3dyiMkmoP4/ANOBiqHTKII+QuAZX7tnoS2VFhdoJHW3RZ7dlYXYXueOkUIUJegVvrzSur1WhI2pZJvTkwKCmTVQ1iU9Ce5mzvT9xYUcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000194.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c03ef3ad-df3a-4ebd-21d1-08deb4e9607f X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700016|14060799003|376014|82310400026|35042699022|56012099003|22082099003|18002099003|4143699003|11063799003; X-Microsoft-Antispam-Message-Info: QYp0bbnrqV9Yg+87FigPK6lvZv3MYzM1PZgxDCWGytS1cvVitK64/pmSJ3a52Ayr6t0sWngP1EkdwXTGsf6qHoc3k2GgqW4duwhJWCFoErJKIao576RNvlA1J5kO/DYO+Dvz6qG6U+rFqVbjXOMKoKZ4m31woy9a4t0x9pOn6po5IUarRNxGQBLGMLnHSKkzK84L0vCL/PkrMyvu9bOoDxzfy+G/GnIJZ4OPeAPy9Wv2NFq7zTRdxcYAtFXKHa3e5Rv4uquGPgXD/qQgsVayW3I9lh1pfMHeqGNMV2c7hhscpW6Oc4DUyTc2VcRbQ2Zu0iHcy7SzR30AZF1NxTgxMMfLSM95XV+/3SrR59urjApRDZU2MNQ+t4c6+iks5tXzb06ymThB80OtaGuY8nUJCeRV3Twnfic9ZmwDc3H8erOFhtTq+gRrzOeGoD2Za/Ng8+AdXFtSsVtirvy3oVvd+eI7TiPAWGCxFkU0PH0yOBUdI3ZASKi1T3J8W+PYXKZrZjDRECcb9elbSQOW+v2ySYm6b+2NJyY3lvneT8wlsuw7bW4uwaWPrh9NZx/QTSELId7xWslBhjyjzIZ3ZgYaPlYodWxiPmB9sn/+XnDscmuhzGcYFJ5wPrEMof7HopIgd/rXFy1NDMmd9T7nNDCsRRurfwHUyI9ihApUeckPM71LJUcK58h2u5Plkn2Yuob1IkEDO1Z2bZ3h95orXXlcRFSs+jqRvaSG2JP65tuhZz4= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700016)(14060799003)(376014)(82310400026)(35042699022)(56012099003)(22082099003)(18002099003)(4143699003)(11063799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8newEsMi80vw2JRLK5xhklVsmEQIknkm4KsG3ygY9Qn10wcRExaBr4nGub5a8MKCnvQwY861QMF/IQ1v99KXKYkHE4ojnY4sEGUvaqq2luK0aGxLkugfDGbNecgT6qW1oWcJ6zrCmYVNmZAi1phK6vBJCOYkcq8QqGhg5BKeeyJ/8EejCqtjH2iRBaP61YOlahkg4eYAAwkS+uj/n3jJMFyFMUmUJzMufpiaZWvFXIaiRFkgiKwXQDzTHQO/+2ra06qdJZbB90LxBsMJk3NKoEy9YNSWia/DYuPOPHAPlhgI8w5qYwdyCwMcWXIHMV9E1jcB6lFz3HvqD5TZjkKFhpSlENT/qaKJ46+bVy9zFQyIHC/nsxGymOBwEjKLLxEV44sM74838NHeHIa5xHE/o3jgnKTjciWG4lLKwcmC76SGH0SC5dQzJXHDcRWvDg57 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2026 14:27:01.0626 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a55900b2-2033-4e81-4bbe-08deb4e9868e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000194.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMDPR08MB11673 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 15/05/2026 17:56, Tom Tromey wrote: >>>>>> Matthieu Longo writes: > >> From: Tom Tromey >> This adds a new gdbpy_borrowed_ref class. This class is primarily for >> code "documentation" purposes -- it makes it clear to the reader that >> a given reference is borrowed. However, it also adds a tiny bit of >> safety, in that conversion to gdbpy_ref<> will acquire a new >> reference. > >> +template >> +class gdbpy_borrowed_ref >> +{ > > On my "safety" branch I ended up rewriting this to have a base class > that allows NULL and a derived class that does not. > > And my initial review -- the one that didn't get sent -- suggested using > this. > > But I tend to think this patch isn't needed yet. It's nice for the > safety series but in this series it is only used a little in patch 2, > and not even every spot that could/should use it -- like I noticed: > > /* PyDict_GetItemWithError returns a borrowed reference. */ > - PyObject *found = PyDict_GetItemWithError (d, file.get ()); > + PyObject *found = PyDict_GetItemWithError (globals, file.get ()); > I can replace the raw PyObject * by gdbpy_borrowed_ref<>. > So on the whole I'd prefer to drop this from this series. That way it > won't conflict or cause problems with the stuff I'm planning to send. > A lot of upcoming patches are using gdbpy_borrowed_ref<> because it simplified a lot the code in some places. Dropping it is going to make things definitely more difficult on my side. > Also you've made this into a template class, which seems alright -- but > not used in the series. Maybe there's some later series depending on > this? That kind of thing is good to mention if so. Yes, it is used later. > > Tom Given those information, do you still want to drop it ? Matthieu