From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60504 invoked by alias); 21 Sep 2017 13:16:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60485 invoked by uid 89); 21 Sep 2017 13:16:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 13:15:56 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8LDFnvY001053 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Sep 2017 09:15:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 1FD141E517; Thu, 21 Sep 2017 09:15:49 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 924381E512; Thu, 21 Sep 2017 09:15:47 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Sep 2017 13:16:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFA] Remove make_cleanup_restore_target_terminal In-Reply-To: <87bmm5nhsw.fsf@tromey.com> References: <20170920160404.20543-1-tom@tromey.com> <313985bd-111f-cea6-7b13-96217ee450cc@redhat.com> <87bmm5nhsw.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Sep 2017 13:15:49 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00628.txt.bz2 On 2017-09-21 00:09, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> + static terminal_state terminal_state;// = terminal_is_ours; > > Pedro> Stale comment? > > Yes, thanks. I'll push without this. > > Tom Clang gives this warning, which seems valid to me: /home/emaisin/src/binutils-gdb/gdb/utils.c:907:23: error: binding reference member 'm_quit_handler' to a temporary value [-Werror,-Wdangling-field] : m_quit_handler (make_scoped_restore (&quit_handler, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/emaisin/src/binutils-gdb/gdb/utils.c:931:18: note: reference member declared here scoped_restore m_quit_handler; ^ Simon