From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7VxHBiCAvGHpCQAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 07:18:40 -0500 Received: by simark.ca (Postfix, from userid 112) id 079631F0CE; Fri, 17 Dec 2021 07:18:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A7DD1F0B9 for ; Fri, 17 Dec 2021 07:18:39 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D567B385842A for ; Fri, 17 Dec 2021 12:18:38 +0000 (GMT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by sourceware.org (Postfix) with ESMTPS id 4D8A03858D28 for ; Fri, 17 Dec 2021 12:18:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D8A03858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f51.google.com with SMTP id i22so3613827wrb.13 for ; Fri, 17 Dec 2021 04:18:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GRFmFVb7pBPYNXvtGIeySWijtmgdO9Q88vhEW18q15A=; b=GiD0CtkMDP4RdkyIv2ydDY03t38CVdFjgtR1310Pjf0rSqq3v2Bt3zixW2KYsuSLyU E2GMKdzdc9Nw05alFgh7tVw5iUDbGLcjlb1E4QLsAckpKrkvouKWYzErCxQeD5X1fukl cshGQLDi9xH5eXNQoSZ7BbHmcI78ZN88cdu3oxVtZDw/i+avBLmWEKrCgE79p6CDF2T8 U1mCMHzjgbrP8IoEcDFE0mtB4apjeUjHaARKi9f0viV5Wv6SJFuoLPlr2j0xqB7tkJ93 +PE6MLxshGYLu16WdPv2nXXTkwWdCTzSXM5GZWKWglBBwuUPwhvmwb8m9kfQyPpuv5uC Fe6Q== X-Gm-Message-State: AOAM531HSdXffayAWVuNMzzFoKbc0iav/YGc3BEPfX2oeZAym+wXMXRY WcMUXN/lGRanVK/Y//uPvaewPopG83A= X-Google-Smtp-Source: ABdhPJwxRDgggmSCU7VqgSOpl0trv1cOg+DuiBs/iCz2LGkxydOE0wuXsGKH1VFKd1xUv1ZwH59/5Q== X-Received: by 2002:adf:9d4c:: with SMTP id o12mr2349100wre.283.1639743506335; Fri, 17 Dec 2021 04:18:26 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id l22sm7164812wmq.2.2021.12.17.04.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 04:18:25 -0800 (PST) Message-ID: Date: Fri, 17 Dec 2021 12:18:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 25/29] gdb/testsuite: Remove duplicates from gdb.base/pointers.exp Content-Language: en-US To: Lancelot SIX References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-26-lsix@lancelotsix.com> <1fbd61ac-abbb-16d1-3f14-400d05dc20d5@palves.net> <20211216231414.kgin6p7nndajxpuk@Plymouth> From: Pedro Alves In-Reply-To: <20211216231414.kgin6p7nndajxpuk@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-16 23:14, Lancelot SIX wrote: > diff --git a/gdb/testsuite/gdb.base/pointers.exp b/gdb/testsuite/gdb.base/pointers.exp > index fa7531d0f85..9916df942d0 100644 > --- a/gdb/testsuite/gdb.base/pointers.exp > +++ b/gdb/testsuite/gdb.base/pointers.exp > @@ -147,14 +147,14 @@ gdb_test "print v_int_pointer > v_int_pointer2" " = $false" \ > > gdb_test_no_output "set variable y = *v_int_pointer++" \ > "set y = *v_int_pointer++" > -gdb_test "print y" " = 6" "pointer assignment" > +gdb_test "print y" " = 6" "pointer assignment, after y = *v_int_pointer++" > gdb_test "print *v_int_pointer" " = 18" "and post-increment" > > > > gdb_test_no_output "set variable y = *--v_int_pointer2" \ > "set y = *--v_int_pointer2" > -gdb_test "print y" " = 6" "pointer assignment" > +gdb_test "print y" " = 6" "pointer assignment, after y = *--v_int_pointer2" > gdb_test "print *v_int_pointer2" " = 6" "and pre-decrement" > > Hmm, how about this instead? with_test_prefix "post-increment" { gdb_test_no_output "set variable y = *v_int_pointer++" \ "pointer dereference, set variable" gdb_test "print y" " = 6" "pointer assignment" gdb_test "print *v_int_pointer" " = 18" "pointer increment" } with_test_prefix "pre-decrement" { gdb_test_no_output "set variable y = *--v_int_pointer2" \ "pointer dereference, set variable" gdb_test "print y" " = 6" "pointer assignment" gdb_test "print *v_int_pointer2" " = 6" "pointer decrement" }