From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36889 invoked by alias); 18 Apr 2017 14:27:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36876 invoked by uid 89); 18 Apr 2017 14:27:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:1048, stock X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 14:27:52 +0000 Received: by simark.ca (Postfix, from userid 33) id E7B8C1E48B; Tue, 18 Apr 2017 10:27:51 -0400 (EDT) To: John Baldwin Subject: Re: [PATCH v2] PR threads/20743: Don't attempt to suspend or resume exited threads. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 18 Apr 2017 14:27:00 -0000 From: Simon Marchi Cc: Luis Machado , gdb-patches@sourceware.org In-Reply-To: <14140503.xzYTI4WuLb@ralph.baldwin.cx> References: <20170404173258.6512-1-jhb@FreeBSD.org> <6029590.iEtzOUCDnR@ralph.baldwin.cx> <14140503.xzYTI4WuLb@ralph.baldwin.cx> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00506.txt.bz2 On 2017-04-17 14:27, John Baldwin wrote: > On Friday, April 14, 2017 08:01:25 PM Luis Machado wrote: >> On 04/14/2017 05:40 PM, John Baldwin wrote: >> >> Otherwise i have no further comments. I assume you ran gdb's testsuite >> >> against this change and verified the results are sane? >> > >> > There were no regressions at least. With the stock tree there are >> > several unexpected failures already which I will get to at some point. >> > >> >> Great. I have no further comments. > > To be clear (since I believe I messed this up before), I still need > approval > from an approver? I read both the v1 and v2 threads to get the context, the patch looks good to me. Pedro was fine with the ALL_NON_EXITED_THREADS approach as well, so go ahead and push. I think it should go in the 8.0 branch as well. Btw, do you know why the double parenthesis in perror_with_name (("ptrace")); ? Feel free to remove the extra parenthesis before pushing. Thanks, Simon