From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51716 invoked by alias); 20 Dec 2018 13:31:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51702 invoked by uid 89); 20 Dec 2018 13:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=citizen, Finally, rpc, thread_info X-HELO: mail-lf1-f67.google.com Received: from mail-lf1-f67.google.com (HELO mail-lf1-f67.google.com) (209.85.167.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Dec 2018 13:31:46 +0000 Received: by mail-lf1-f67.google.com with SMTP id l10so1354917lfh.9 for ; Thu, 20 Dec 2018 05:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:reply-to:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=TscDbClyh30r8kpEwOdeLwUC8sBXR4F2swmeNrTB550=; b=kr1K2lqPgNNr6VFM1U8VyrBHpKOpTQYfRFM1GnMvV0visQLwCZIj5KZjMsJv/LFU/2 DA2+/qdKRbY2dU5eelLcUjJNHnDg2WMtS9zIuDQgnB1UNh5ovGej7eWM7g7tm2eyYL6g AD8p0LtgPiXgS+hW16Lq9Qqg36oyeW6ACWMlnnWqSrAWr1Pc1c9Tq7ylmvXQgQ+rI67d OlbrHZH/W+9wJdZ5txknHnEImkOP+Ng1yxJq8Vo7w1OKIAFQ8eBEGUniF3N5SjOQeJvH ZThHNgj+dF+ZwWnnrFSiulHNKHy1TQE+KQ/TAShEByc4Hdk6GSX1+RsLlzLxl2YXDnD4 lEWw== Return-Path: Received: from [192.168.1.77] (2-248-159-26-no549.tbcn.telia.com. [2.248.159.26]) by smtp.googlemail.com with ESMTPSA id b25sm4283044lfa.96.2018.12.20.05.31.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Dec 2018 05:31:42 -0800 (PST) Message-ID: Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff) From: Svante Signell Reply-To: svante.signell@gmail.com To: Tom Tromey Cc: Andreas Schwab , Simon Marchi , gdb-patches@sourceware.org Date: Thu, 20 Dec 2018 13:31:00 -0000 In-Reply-To: References: <000db1d81a0c415190b6648222ed29db7f927df9.camel@gmail.com> <87d0q13w6b.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-12/txt/msg00233.txt.bz2 On Mon, 2018-12-17 at 21:51 +0100, Svante Signell wrote: > On Sun, 2018-12-16 at 16:10 -0700, Tom Tromey wrote: > > Svante> Finally, I've found the problem (but no workaround yet): > > thread_info is an RPC on GNU/Hurd, and including mach.h in > > gdb/config/i386/nm-i386gnu.h:#include further includes > > which has the conflicting name of that RPC: > > kern_return_t thread_info > > > > Typical answers for this kind of thing are either to segregate the > > use of the system header somehow, or maybe namespacing or some > > other kind of renaming. I haven't looked into the details much in > > this case I'm afraid. > > As I see it you need to: > > 1) Apply the patches submitted earlier in this thread using struct > thread_info > consistently everywhere (simplest). > 2) Rename all usage of the struct thread_info to something else e.g. > struct gdb_thread_info (not future-proof though). > 3) Create a gdb namespace for all your code to avoid conflicts. > 4) Segregate the use of system header files as you write above. Dunno > how to do that though, but some of you should. Hi again. Seem like I did not get the reply from John Baldwin on this thread, some gmail issue? Can somebody forward it to me, I've only seen it on the mailing list archives: https://sourceware.org/ml/gdb-patches/ 2018-12/msg00202.html Seems like nothing is happening so far. Did you expect me to take action on this issue? Or is this a low-prio problem for you, Hurd being a second class citizen?