From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iepQOGsMN2ge2DcAWB0awg (envelope-from ) for ; Wed, 28 May 2025 09:15:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=AKfZgyZS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D623C1E11C; Wed, 28 May 2025 09:15:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.0 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 87EC91E102 for ; Wed, 28 May 2025 09:15:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28541385735A for ; Wed, 28 May 2025 13:15:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28541385735A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=AKfZgyZS Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by sourceware.org (Postfix) with ESMTPS id D13BD3857723 for ; Wed, 28 May 2025 13:14:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D13BD3857723 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=partner.samsung.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=partner.samsung.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D13BD3857723 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=210.118.77.12 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748438083; cv=none; b=TuG8cuS491OFstJy9aTZqbE0QwIOnyYS7oWj/pAFbgMfYw/vqrSSMhBubrSB8Se4gRT/DDopqvxnKTPWPB5XEDKgU38lZ1Po4zR/G87ZsnL9ac+2LYMVJuDeMS7Jjd7nWRWYMzm47gMlj2qJTj5jyI5YREwcOm1WOwchIptrbU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748438083; c=relaxed/simple; bh=JDbyp6860n0DTJp4NEFySF8zsQn8fnIqsLvQ3Ls9tcE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xoGLEtizKRx07E/NF5SdLzJkN6ew4rVuM8m5P2tzN2yT7F6ZJ5HTvOSIXKhN7YtMzdABWoKqW6QpcSOdcfutgjh6bmb3VbimUceWeWBFDrXoeO+Alp1p7Pn9eirqTNX23D7lP38nuomltwYYVcOEJYnDp7kni/5sEN1Amhwfasg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D13BD3857723 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250528131441euoutp021472a1bfc4b09fefb4594a4592265410~Dsyv9iPoq0820908209euoutp02S for ; Wed, 28 May 2025 13:14:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250528131441euoutp021472a1bfc4b09fefb4594a4592265410~Dsyv9iPoq0820908209euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1748438081; bh=NLfPpywjEmAzaJ38460KlQm2bd8f+AnYH/Buay6Mbao=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=AKfZgyZSi0Pofqd+Chz0MrYPSPqEnY0C9I/eQAHZhF2e8mXc2VV6JxQSC0UW39ZpD /kUYXY935TgicPbcM6908S/PkuhG8zRjqsKukqOCm0bPRYTooBgZRVaPUP50g5d6Cn DLEMv0YT65/bfq/7ME4QACh4wU6BNyZqXeOS4900= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250528131441eucas1p1d4e5c15c092bd1f415e000c810fbc90c~DsyvqpQ4w0522605226eucas1p1m; Wed, 28 May 2025 13:14:41 +0000 (GMT) Received: from [106.210.135.145] (unknown [106.210.135.145]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250528131441eusmtip1b382a7d4d5638a1d4f1f97f467792eeb~DsyvMel3j1125111251eusmtip1K; Wed, 28 May 2025 13:14:41 +0000 (GMT) Message-ID: Date: Wed, 28 May 2025 15:14:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: Fix ISA string detection for disassembly To: gdb-patches@sourceware.org Cc: s.rutka@samsung.com, palmer@dabbelt.com, andrew@sifive.com, jim.wilson.gcc@gmail.com, nelson@rivosinc.com, f.wasil@samsung.com Content-Language: en-GB From: Marek Pikula In-Reply-To: <20250528115447.2750177-1-m.pikula@partner.samsung.com> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20250528131441eucas1p1d4e5c15c092bd1f415e000c810fbc90c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250528115450eucas1p1e57249bb51f4b7f41741772f60186468 X-EPHeader: CA X-CMS-RootMailID: 20250528115450eucas1p1e57249bb51f4b7f41741772f60186468 References: <20250528115447.2750177-1-m.pikula@partner.samsung.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch addresses previous feedback from Andrew Burgess. On 28.05.2025 13:54, Marek Pikuła wrote: > Commit 3f61a38 introduced a regression where the ISA string was no > longer detected based on the ELF header. The mechanism was changed from > directly referencing `abfd` to using `disassembler_info->section`, which > was not properly initialized for RISC-V. > > The previous implementation ignored the object in scope, leading to > issues such as failing to decode RVV instructions when a library was > compiled as `rv64gcv` and the main application as `rv64gc`. > > This patch resolves both problems by initializing > `disassembler_info->section` with the object currently in scope, > ensuring correct ISA string detection during disassembly. > > Signed-off-by: Marek Pikuła > --- > gdb/riscv-tdep.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index 8998a297315..01e5dd00153 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -4163,6 +4163,19 @@ riscv_gnu_triplet_regexp (struct gdbarch *gdbarch) > return "riscv(32|64)?"; > } > > +/* Implement the "print_insn" gdbarch method. */ > +static int > +riscv_print_insn (bfd_vma addr, struct disassemble_info *info) > +{ > + /* Initialize the BFD section to enable ISA string detection depending on the > + object in scope. */ > + struct obj_section *s = find_pc_section (addr); > + if (s != nullptr) > + info->section = s->the_bfd_section; > + > + return default_print_insn (addr, info); > +} > + > /* Implementation of `gdbarch_stap_is_single_operand', as defined in > gdbarch.h. */ > > @@ -4429,6 +4442,9 @@ riscv_gdbarch_init (struct gdbarch_info info, > disassembler_options_riscv ()); > set_gdbarch_disassembler_options (gdbarch, &riscv_disassembler_options); > > + /* Disassembler print_insn. */ > + set_gdbarch_print_insn (gdbarch, riscv_print_insn); > + > /* SystemTap Support. */ > set_gdbarch_stap_is_single_operand (gdbarch, riscv_stap_is_single_operand); > set_gdbarch_stap_register_indirection_prefixes > -- > 2.49.0 >