From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80900 invoked by alias); 5 Dec 2019 18:47:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80892 invoked by uid 89); 5 Dec 2019 18:47:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=UD:a.m, am, a.m X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 18:47:45 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id xB5IlbII012361 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Dec 2019 13:47:42 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca xB5IlbII012361 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1575571663; bh=4vRXPXehC/qqTKsAR/1zh5N8JnG6UqfJNebC3Qjxug0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Fh18W/bYy9E6I3yPBuBN9TQzVh/gQYXobaQ5489mkF07FRg+RvsuuP4W3HVPtbSs4 L3OXOdxFK6nmISMZHn7lI2toiC2fuyKrq7vs1YkffzUdwcN+8uIpw4iLNU/W1atxeE CEzJHovN5TuZeTSYzHpqQCg/WuhgXHqlAe1zdsMI= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 64C561E5F1; Thu, 5 Dec 2019 13:47:37 -0500 (EST) Subject: Re: [PATCH] Remove gdbarch parameter of lookup_typename To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20191205050916.230459-1-simon.marchi@polymtl.ca> <87sgly96or.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Thu, 05 Dec 2019 18:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <87sgly96or.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00202.txt.bz2 On 2019-12-05 9:40 a.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I noticed that the gdbarch parameter of lookup_typename was unused, so I > Simon> removed it (as well as from lookup_signed_typename and > Simon> lookup_unsigned_typename) and updated all callers. > > This looks fine to me. Thanks for doing this. > > I do wonder a bit why the parameter was there in the first place. Maybe > this code used to look at the per-arch types? > > Tom > I looked up the commit that removed the use of gdbarch, here it is: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1994afbf19892c9e614a034fbf1a5233e9addce3 This seems to be the corresponding message on gdb-patches: https://sourceware.org/ml/gdb-patches/2014-12/msg00521.html It looks like the series may have been pushed as one squashed commit? Anyway, it looks indeed like were looking up primitive types using the gdbarch before, I can't explain why that changed without digging deeper, but I'll suppose that change was correct. I will push the patch as soon as I confirmed it's still building. Simon